From: Roman Penyaev <roman.penyaev@profitbricks.com>
To: Tejun Heo <tj@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
David Howells <dhowells@redhat.com>
Subject: Re: [PATCH 1/1] [RFC] workqueue: fix ghost PENDING flag while doing MQ IO
Date: Mon, 25 Apr 2016 18:40:59 +0200 [thread overview]
Message-ID: <CAJrWOzD_+gJ16cE8va10jLq_CQgywna+o8mYkwz=VftxWRjsUQ@mail.gmail.com> (raw)
In-Reply-To: <20160425160023.GA7822@mtj.duckdns.org>
On Mon, Apr 25, 2016 at 6:00 PM, Tejun Heo <tj@kernel.org> wrote:
> On Mon, Apr 25, 2016 at 11:48:47AM -0400, Tejun Heo wrote:
>> Heh, excellent debugging. I wonder how old this bug is. cc'ing David
>
> I just went through the history. So, we used to have clear_bit()
> instead of atomic_long_set() but clear_bit() doesn't imply any barrier
> either, so kudos to you. You just debugged an issue which is most
> likely has been there for over a decade! :)
That's nice, that we can finally fix it.
But as I was saying I was just lucky enough to have very easy reproduction.
I could check all crazy ideas I had :)
--
Roman
next prev parent reply other threads:[~2016-04-25 16:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 15:22 [PATCH 1/1] [RFC] workqueue: fix ghost PENDING flag while doing MQ IO Roman Pen
2016-04-25 15:48 ` Tejun Heo
2016-04-25 16:00 ` Tejun Heo
2016-04-25 16:40 ` Roman Penyaev [this message]
2016-04-25 16:34 ` Roman Penyaev
2016-04-25 17:03 ` Tejun Heo
2016-04-25 17:39 ` Roman Penyaev
2016-04-25 17:51 ` Tejun Heo
2016-04-26 1:22 ` Peter Hurley
2016-04-26 15:15 ` Tejun Heo
2016-04-26 17:27 ` Peter Hurley
2016-04-26 17:45 ` Tejun Heo
2016-04-26 20:07 ` Peter Hurley
2016-04-27 5:50 ` Hannes Reinecke
2016-04-27 19:05 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJrWOzD_+gJ16cE8va10jLq_CQgywna+o8mYkwz=VftxWRjsUQ@mail.gmail.com' \
--to=roman.penyaev@profitbricks.com \
--cc=axboe@kernel.dk \
--cc=dhowells@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.