Re: [PATCH v4 3/3] printk: Remove redundant CONFIG_BASE_FULL

From: Masahiro Yamada <masahiroy@kernel.org>
To: Yoann Congal <yoann.congal@smile.fr>
Cc: linux-fsdevel@vger.kernel.org, linux-kbuild@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	x86@kernel.org, "André Almeida" <andrealmeid@igalia.com>,
	"Borislav Petkov" <bp@alien8.de>,
	"Darren Hart" <dvhart@infradead.org>,
	"Dave Hansen" <dave.hansen@linux.intel.com>,
	"Davidlohr Bueso" <dave@stgolabs.net>,
	"Geert Uytterhoeven" <geert@linux-m68k.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"H . Peter Anvin" <hpa@zytor.com>,
	"Ingo Molnar" <mingo@redhat.com>,
	"Jiri Slaby" <jirislaby@kernel.org>,
	"John Ogness" <john.ogness@linutronix.de>,
	"Josh Triplett" <josh@joshtriplett.org>,
	"Matthew Wilcox" <willy@infradead.org>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Petr Mladek" <pmladek@suse.com>,
	"Sergey Senozhatsky" <senozhatsky@chromium.org>,
	"Steven Rostedt" <rostedt@goodmis.org>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Willem de Bruijn" <willemdebruijn.kernel@gmail.com>
Subject: Re: [PATCH v4 3/3] printk: Remove redundant CONFIG_BASE_FULL
Date: Tue, 6 Feb 2024 22:25:43 +0900	[thread overview]
Message-ID: <CAK7LNARUdHkihZhdw54i1Yx=Ew7vQqmXCF_D6O3r3hMbMFev0g@mail.gmail.com> (raw)
In-Reply-To: <20240206001333.1710070-4-yoann.congal@smile.fr>

On Tue, Feb 6, 2024 at 9:13 AM Yoann Congal <yoann.congal@smile.fr> wrote:
>
> CONFIG_BASE_FULL is equivalent to !CONFIG_BASE_SMALL and is enabled by
> default: CONFIG_BASE_SMALL is the special case to take care of.
> So, remove CONFIG_BASE_FULL and move the config choice to
> CONFIG_BASE_SMALL (which defaults to 'n')
>
> Signed-off-by: Yoann Congal <yoann.congal@smile.fr>
> ---
> v3->v4:
> * Split "switch CONFIG_BASE_SMALL to bool" and "Remove the redundant
>   config" (this patch) into two patches
> * keep CONFIG_BASE_SMALL instead of CONFIG_BASE_FULL
> ---
>  init/Kconfig | 13 ++++---------
>  1 file changed, 4 insertions(+), 9 deletions(-)
>
> diff --git a/init/Kconfig b/init/Kconfig
> index d4b16cad98502..4ecf2572d00ee 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -1581,11 +1581,11 @@ config PCSPKR_PLATFORM
>           This option allows to disable the internal PC-Speaker
>           support, saving some memory.
>
> -config BASE_FULL
> -       default y
> -       bool "Enable full-sized data structures for core" if EXPERT
> +config BASE_SMALL
> +       default n

A nit.

Please drop the redundant 'default n' next time
(as it seems you will have a change to send v5)

> +       bool "Enable smaller-sized data structures for core" if EXPERT
>         help
> -         Disabling this option reduces the size of miscellaneous core
> +         Enabling this option reduces the size of miscellaneous core
>           kernel data structures. This saves memory on small machines,
>           but may reduce performance.
>
> @@ -1940,11 +1940,6 @@ config RT_MUTEXES
>         bool
>         default y if PREEMPT_RT
>
> -config BASE_SMALL
> -       bool
> -       default y if !BASE_FULL
> -       default n
> -
>  config MODULE_SIG_FORMAT
>         def_bool n
>         select SYSTEM_DATA_VERIFICATION
> --
> 2.39.2
>

-- 
Best Regards
Masahiro Yamada