From: Masahiro Yamada <masahiroy@kernel.org>
To: 3090101217@zju.edu.cn
Cc: Michal Marek <michal.lkml@markovi.net>,
Nick Desaulniers <ndesaulniers@google.com>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jing Leng <jleng@ambarella.com>
Subject: Re: [PATCH] kbuild: Fix include path in scripts/Makefile.modpost
Date: Tue, 24 May 2022 02:52:45 +0900 [thread overview]
Message-ID: <CAK7LNARs__+bdMMb0c8whxxzfkcN7U1yjm5PCddqZqshW2o=Cw@mail.gmail.com> (raw)
In-Reply-To: <20220517105128.9720-1-3090101217@zju.edu.cn>
On Tue, May 17, 2022 at 7:51 PM <3090101217@zju.edu.cn> wrote:
>
> From: Jing Leng <jleng@ambarella.com>
>
> When building an external module, if users don't need to separate the
> compilation output and source code, they run the following command:
> "make -C $(LINUX_SRC_DIR) M=$(PWD)". At this point, "$(KBUILD_EXTMOD)"
> and "$(src)" are the same.
>
> If they need to separate them, they run "make -C $(KERNEL_SRC_DIR)
> O=$(KERNEL_OUT_DIR) M=$(OUT_DIR) src=$(PWD)". Before running the
> command, they need to copy "Kbuild" or "Makefile" to "$(OUT_DIR)" to
> prevent compilation failure.
>
> So the kernel should change the included path to avoid the copy operation.
>
> Signed-off-by: Jing Leng <jleng@ambarella.com>
> ---
> scripts/Makefile.modpost | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/scripts/Makefile.modpost b/scripts/Makefile.modpost
> index 48585c4d04ad..0273bf7375e2 100644
> --- a/scripts/Makefile.modpost
> +++ b/scripts/Makefile.modpost
> @@ -87,8 +87,7 @@ obj := $(KBUILD_EXTMOD)
> src := $(obj)
>
> # Include the module's Makefile to find KBUILD_EXTRA_SYMBOLS
> -include $(if $(wildcard $(KBUILD_EXTMOD)/Kbuild), \
> - $(KBUILD_EXTMOD)/Kbuild, $(KBUILD_EXTMOD)/Makefile)
> +include $(if $(wildcard $(src)/Kbuild), $(src)/Kbuild, $(src)/Makefile)
>
> # modpost option for external modules
> MODPOST += -e
> --
> 2.17.1
>
I do not think "M=$(OUT_DIR) src=$(PWD)" is the official way,
but this patch is a clean up.
Applied to linux-kbuild. Thanks.
--
Best Regards
Masahiro Yamada
prev parent reply other threads:[~2022-05-23 18:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 10:51 [PATCH] kbuild: Fix include path in scripts/Makefile.modpost 3090101217
2022-05-23 17:52 ` Masahiro Yamada [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK7LNARs__+bdMMb0c8whxxzfkcN7U1yjm5PCddqZqshW2o=Cw@mail.gmail.com' \
--to=masahiroy@kernel.org \
--cc=3090101217@zju.edu.cn \
--cc=jleng@ambarella.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.