From: Masahiro Yamada <masahiroy@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Michal Marek <michal.lkml@markovi.net>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
X86 ML <x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] x86: Drop generated syscall headers from 'targets'
Date: Wed, 24 Feb 2021 09:47:07 +0900 [thread overview]
Message-ID: <CAK7LNARzTpczHuuHam5kHkaG1UhFE05knp5KeEcd5=Cv_EQEsw@mail.gmail.com> (raw)
In-Reply-To: <20210223181425.4010665-3-robh@kernel.org>
On Wed, Feb 24, 2021 at 3:14 AM Rob Herring <robh@kernel.org> wrote:
>
> Including the generated syscall headers in 'targets' is wrong because they
> are not built in $(obj)/ and the Makefile does its own path prefix and
> build rules.
>
> Cc: Andy Lutomirski <luto@kernel.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: x86@kernel.org
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: Masahiro Yamada <masahiroy@kernel.org>
> Cc: Michal Marek <michal.lkml@markovi.net>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> arch/x86/entry/syscalls/Makefile | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/x86/entry/syscalls/Makefile b/arch/x86/entry/syscalls/Makefile
> index 6fb9b57ed5ba..b0dcb7e41554 100644
> --- a/arch/x86/entry/syscalls/Makefile
> +++ b/arch/x86/entry/syscalls/Makefile
> @@ -62,8 +62,6 @@ syshdr-$(CONFIG_X86_64) += unistd_32_ia32.h unistd_64_x32.h
> syshdr-$(CONFIG_X86_64) += syscalls_64.h
> syshdr-$(CONFIG_XEN) += xen-hypercalls.h
>
> -targets += $(uapisyshdr-y) $(syshdr-y)
> -
This is also a wrong fix.
The correct fix exists in linux-next.
commit 865fa29f7dd1b6af8498fe08f19b4028c1c8a153
Author: Masahiro Yamada <masahiroy@kernel.org>
Date: Mon Feb 15 09:48:22 2021 +0900
arch: syscalls: add missing FORCE and fix 'targets' to make if_changed work
I will send a PR this week.
> PHONY += all
> all: $(addprefix $(uapi)/,$(uapisyshdr-y))
> all: $(addprefix $(out)/,$(syshdr-y))
> --
> 2.27.0
>
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2021-02-24 1:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 18:14 [PATCH 0/3] Build time gitignore checking Rob Herring
2021-02-23 18:14 ` [PATCH 1/3] kbuild: Make old-atomics and missing-syscalls phony targets Rob Herring
2021-02-24 0:43 ` Masahiro Yamada
2021-02-24 1:12 ` Rob Herring
2021-02-23 18:14 ` [PATCH 2/3] x86: Drop generated syscall headers from 'targets' Rob Herring
2021-02-24 0:47 ` Masahiro Yamada [this message]
2021-02-23 18:14 ` [PATCH 3/3] kbuild: Add a build check for missing gitignore entries Rob Herring
2021-02-23 23:19 ` Linus Torvalds
2021-02-23 23:59 ` Rob Herring
2021-02-24 1:14 ` Masahiro Yamada
2021-02-24 11:26 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK7LNARzTpczHuuHam5kHkaG1UhFE05knp5KeEcd5=Cv_EQEsw@mail.gmail.com' \
--to=masahiroy@kernel.org \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=mingo@redhat.com \
--cc=robh@kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.