From: Masahiro Yamada <masahiroy@kernel.org>
To: Brian Gerst <brgerst@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
X86 ML <x86@kernel.org>, Andy Lutomirski <luto@kernel.org>,
Borislav Petkov <bp@alien8.de>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH 1/3] x86/uml/syscalls: Remove array index from syscall initializers
Date: Tue, 25 May 2021 20:22:13 +0900 [thread overview]
Message-ID: <CAK7LNAS1-4+PrP15ZRpkWB0boX-2b_gYa9gg8_HR5jOmG4HWiw@mail.gmail.com> (raw)
In-Reply-To: <20210524181707.132844-2-brgerst@gmail.com>
On Tue, May 25, 2021 at 3:17 AM Brian Gerst <brgerst@gmail.com> wrote:
>
> Commit 44fe4895f47c ("Stop filling syscall arrays with *_sys_ni_syscall")
> removed the index from the initializers for native x86 syscall tables, but
> missed the UML syscall tables.
Ah, right.
I missed cleaning up this in UML. Thanks.
Reviewed-by: Masahiro Yamada <masahiroy@kernel.org>
> Signed-off-by: Brian Gerst <brgerst@gmail.com>
> ---
> arch/x86/um/sys_call_table_32.c | 2 +-
> arch/x86/um/sys_call_table_64.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/um/sys_call_table_32.c b/arch/x86/um/sys_call_table_32.c
> index f8323104e353..0575decb5e54 100644
> --- a/arch/x86/um/sys_call_table_32.c
> +++ b/arch/x86/um/sys_call_table_32.c
> @@ -31,7 +31,7 @@
> #include <asm/syscalls_32.h>
>
> #undef __SYSCALL
> -#define __SYSCALL(nr, sym) [ nr ] = sym,
> +#define __SYSCALL(nr, sym) sym,
>
> extern asmlinkage long sys_ni_syscall(unsigned long, unsigned long, unsigned long, unsigned long, unsigned long, unsigned long);
>
> diff --git a/arch/x86/um/sys_call_table_64.c b/arch/x86/um/sys_call_table_64.c
> index 5ed665dc785f..95725b5a41ac 100644
> --- a/arch/x86/um/sys_call_table_64.c
> +++ b/arch/x86/um/sys_call_table_64.c
> @@ -39,7 +39,7 @@
> #include <asm/syscalls_64.h>
>
> #undef __SYSCALL
> -#define __SYSCALL(nr, sym) [ nr ] = sym,
> +#define __SYSCALL(nr, sym) sym,
>
> extern asmlinkage long sys_ni_syscall(unsigned long, unsigned long, unsigned long, unsigned long, unsigned long, unsigned long);
>
> --
> 2.31.1
>
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2021-05-25 11:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-24 18:17 [PATCH 0/3] x86: Syscall table cleanups Brian Gerst
2021-05-24 18:17 ` [PATCH 1/3] x86/uml/syscalls: Remove array index from syscall initializers Brian Gerst
2021-05-25 11:22 ` Masahiro Yamada [this message]
2021-05-25 15:00 ` [tip: x86/entry] " tip-bot2 for Brian Gerst
2021-05-24 18:17 ` [PATCH 2/3] x86/syscalls: Remove -Wno-override-init for syscall tables Brian Gerst
2021-05-25 12:01 ` Masahiro Yamada
2021-05-25 15:00 ` [tip: x86/entry] " tip-bot2 for Brian Gerst
2021-05-24 18:17 ` [PATCH 3/3] x86/syscalls: Don't sdjust CFLAGS " Brian Gerst
2021-05-25 12:01 ` Masahiro Yamada
2021-05-25 15:00 ` [tip: x86/entry] x86/syscalls: Don't adjust " tip-bot2 for Brian Gerst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNAS1-4+PrP15ZRpkWB0boX-2b_gYa9gg8_HR5jOmG4HWiw@mail.gmail.com \
--to=masahiroy@kernel.org \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.