Re: [PATCHv2] kconfig: add some Kconfig env variables to make help

From: Masahiro Yamada <masahiroy@kernel.org>
To: Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2] kconfig: add some Kconfig env variables to make help
Date: Thu, 29 Feb 2024 12:36:57 +0900	[thread overview]
Message-ID: <CAK7LNASujf8m4PpMyoCC1cTN_YGeG1HVaOR+3pZx5=3OJp=85A@mail.gmail.com> (raw)
In-Reply-To: <20240229021010.GM11972@google.com>

On Thu, Feb 29, 2024 at 11:10 AM Sergey Senozhatsky
<senozhatsky@chromium.org> wrote:
>
> On (24/02/29 11:03), Masahiro Yamada wrote:
> > > > > > +++ b/scripts/kconfig/Makefile
> > > > > > @@ -158,6 +158,10 @@ help:
> > > > > >                 if help=$$(grep -m1 '^# Help: ' $(f)); then \
> > > > > >                         printf '  %-25s - %s\n' '$(notdir $(f))' "$${help#*: }"; \
> > > > > >                 fi;)
> > > > > > +       @echo  ''
> > > > > > +       @echo  'Configuration environment variables:'
> > > > > > +       @echo  '  KCONFIG_WERROR                 - Turn some Kconfig warnings into error conditions'
> > > > > > +       @echo  '  KCONFIG_WARN_UNKNOWN_SYMBOLS   - Make Kconfig warn about all unrecognized config symbols'
> > > > > >
> > > > > >  # ===========================================================================
> > > > > >  # object files used by all kconfig flavours
> > > > > > --
> > > > > > 2.44.0.rc0.258.g7320e95886-goog
> > > > > >
> > > > > >
> > > > >
> > > > > Why only two, while Kconfig supports more env variables?
> > > >
> > > > Right.  I wanted to add only those that we use (and familiar with) for
> > > > starters.  I'm not familiar with things like KCONFIG_PROBABILITY, for
> > > > instance, and not sure how to document it (its Documentation/kbuild/kconfig.rst
> > > > description is pretty lengthy).
> > >
> > > Masahiro, any opinion?
> >
> >
> > I do not need this patch.
>
> Do you agree that putting kconfig env knobs into help makes sense
> in general?  Especially those add valuable sanity checks.

I cannot accept the attitude:
  "I am interested only in these. I do not care about the rest,
  as keeping the correctness and consistency is the
  work for somebody else (= very likely the maintainer)"

This should be all or nothing.

I do not think all the env variables can be summarized
to fit in help.

--
Best Regards
Masahiro Yamada