Re: [PATCH] kbuild: /bin/pwd -> pwd

From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: "Bjørn Forsman" <bjorn.forsman@gmail.com>
Cc: Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
	Michal Marek <mmarek@suse.com>,
	Jan Kiszka <jan.kiszka@siemens.com>,
	Kieran Bingham <kieran@ksquared.org.uk>
Subject: Re: [PATCH] kbuild: /bin/pwd -> pwd
Date: Thu, 17 Aug 2017 00:31:22 +0900	[thread overview]
Message-ID: <CAK7LNATj+oidNg_FTpa57BfUK=kBNhHzs8wdbobCFbQaagV2RA@mail.gmail.com> (raw)
In-Reply-To: <CAEYzJUEgX4+1b0c8jqC7TALWZkKqLiqE0HMvB1zqHrEfv9yEEg@mail.gmail.com>

Hi.

2017-08-12 21:00 GMT+09:00 Bjørn Forsman <bjorn.forsman@gmail.com>:
> Hi,
>
> On 12 August 2017 at 05:26, Masahiro Yamada
> <yamada.masahiro@socionext.com> wrote:
>> Hi.
>>
>> 2017-07-24 23:20 GMT+09:00 Bjørn Forsman <bjorn.forsman@gmail.com>:
>>> Several places already use pwd and rely on $PATH lookup. Moving the
>>> remaining /bin/pwd users over for consistency.
>>>
>>> Also, a reason for doing /bin/pwd -> pwd instead of the other way around
>>> is because I believe build systems should make little assumptions on host
>>> filesystem layout. Case in point, we do this kind of patching already in
>>> NixOS.
>> [...]
>> Could you use $(abspath ...) instead of $(shell cd ... && /bin/pwd) ?
>> [...]
>> This one should use $(realpath ...) instead of $(abspath ...), I think.
>>
>> The difference between them is that
>> $(realpath ...) returns an empty string if the given path does not exist.
>
> That sounds like possibly changing semantics. I'd prefer to keep the
> patch as is, since I'm not familiar with the side effects of inserting
> relative vs absolute paths here. Is that OK for you?
>

I prefer abspath/realpath.

If you are reluctant to do it, I will take a look.

-- 
Best Regards
Masahiro Yamada