Re: [PATCH] hexagon: select GENERIC_IRQ_PROBE instead of redefining it

From: Masahiro Yamada <masahiroy@kernel.org>
To: Brian Cain <bcain@quicinc.com>
Cc: "linux-kbuild@vger.kernel.org" <linux-kbuild@vger.kernel.org>,
	 "linux-hexagon@vger.kernel.org" <linux-hexagon@vger.kernel.org>,
	 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] hexagon: select GENERIC_IRQ_PROBE instead of redefining it
Date: Fri, 16 Feb 2024 11:03:16 +0900	[thread overview]
Message-ID: <CAK7LNATt+0nBzO+UBOZhdkjmyYyzgU+VfG4eNxMCYvFmB-z2Sw@mail.gmail.com> (raw)
In-Reply-To: <CH3PR02MB1024753D597A02B754FEE1D85B84D2@CH3PR02MB10247.namprd02.prod.outlook.com>

On Fri, Feb 16, 2024 at 4:12 AM Brian Cain <bcain@quicinc.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Masahiro Yamada <masahiroy@kernel.org>
> > Sent: Thursday, February 15, 2024 8:08 AM
> > To: linux-kbuild@vger.kernel.org
> > Cc: Masahiro Yamada <masahiroy@kernel.org>; Brian Cain
> > <bcain@quicinc.com>; linux-hexagon@vger.kernel.org; linux-
> > kernel@vger.kernel.org
> > Subject: [PATCH] hexagon: select GENERIC_IRQ_PROBE instead of redefining it
> >
> > WARNING: This email originated from outside of Qualcomm. Please be wary of
> > any links or attachments, and do not enable macros.
> >
> > Select GENERIC_IRQ_PROBE, as the other architectures do.
> >
> > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> > ---
> >
> >  arch/hexagon/Kconfig | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/arch/hexagon/Kconfig b/arch/hexagon/Kconfig
> > index e922026fef09..a8dd2501f39f 100644
> > --- a/arch/hexagon/Kconfig
> > +++ b/arch/hexagon/Kconfig
> > @@ -21,6 +21,7 @@ config HEXAGON
> >         select HAVE_PERF_EVENTS
> >         # GENERIC_ALLOCATOR is used by dma_alloc_coherent()
> >         select GENERIC_ALLOCATOR
> > +       select GENERIC_IRQ_PROBE
> >         select GENERIC_IRQ_SHOW
> >         select HAVE_ARCH_KGDB
> >         select HAVE_ARCH_TRACEHOOK
> > @@ -60,9 +61,6 @@ config GENERIC_CSUM
> >  #
> >  # Use the generic interrupt handling code in kernel/irq/:
> >  #
> > -config GENERIC_IRQ_PROBE
> > -       def_bool y
> > -
> >  config GENERIC_HWEIGHT
> >         def_bool y
> >
> > --
> > 2.40.1
>
> Acked-by: Brian Cain <bcain@quicinc.com>
>

Thanks for the ack.

I will also delete the comment lines above:

#
# Use the generic interrupt handling code in kernel/irq/:
#

BTW, the reason why I submitted this to linux-kbuild ML
is I did not see any hexagon pull requests
in the past few years.

(I am doing the same for sparc, alpha as well)

-- 
Best Regards
Masahiro Yamada