From: Arnd Bergmann <arnd@arndb.de>
To: Vladimir Murzin <vladimir.murzin@arm.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Russell King - ARM Linux <linux@armlinux.org.uk>,
Mark Rutland <mark.rutland@arm.com>,
Marc Zyngier <maz@kernel.org>, Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [PATCH 2/2] irqchip: nvic: Use GENERIC_IRQ_MULTI_HANDLER
Date: Wed, 1 Dec 2021 15:05:59 +0100 [thread overview]
Message-ID: <CAK8P3a1fe8L7FpsRCgA8f26GzhDUW5NZqvFkQH=fx_PigJmrrg@mail.gmail.com> (raw)
In-Reply-To: <26a97bb9-9b00-b162-8924-6b77309365b8@arm.com>
On Wed, Dec 1, 2021 at 2:43 PM Vladimir Murzin <vladimir.murzin@arm.com> wrote:
> On 12/1/21 12:30 PM, Arnd Bergmann wrote:
> > On Wed, Dec 1, 2021 at 12:02 PM Vladimir Murzin <vladimir.murzin@arm.com> wrote:
> >>
> >> Rather then restructuring the ARMv7M entrly logic per TODO, just move
> >> NVIC to GENERIC_IRQ_MULTI_HANDLER.
> >>
> >> Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com>
> >
> > Acked-by: Arnd Bergmann <arnd@arndb.de>
> >
> > Thanks for finishing this one off as well! I don't know if you did this as a
> > reaction to me doing the same for the three other platforms that don't
> > use GENERIC_IRQ_MULTI_HANDLER yet[1], or if this was just a lucky
> > coincidence. It sounds like this should be part of Ard's IRQ stack series
> > as well then (adding him to Cc), as it fits in with my patches there.
>
> It was reaction to Mark's TODO statement in his original submission [1].
> I'd let maintainers to decide on the path it should land :)
Ah, nice, so it was a coincidence after all. I guess my patches were easier
because of Mark's (and Marc's) earlier work on related bits.
> > Would you mind also implementing and testing the missing bits
> > for the stack switching on nommu irq entry, corresponding to [2] so
> > we can just use that part unconditionally as well?
>
> I can have a look but no promises since I have few issues with NOMMU
> ATM (one of them seems to be cross-arch [2])
Yes, I saw that, but I'm not too worried about this on Arm, as we don't
support that combination (SMP without MMU) in any of our platforms or
in Kconfig without additional patches.
What target are you actually testing on?
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-12-01 14:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-01 11:02 [PATCH 1/2] irqchip: nvic: Fix offset for Interrupt Priority Offsets Vladimir Murzin
2021-12-01 11:02 ` [PATCH 2/2] irqchip: nvic: Use GENERIC_IRQ_MULTI_HANDLER Vladimir Murzin
2021-12-01 11:58 ` Mark Rutland
2021-12-01 12:30 ` Arnd Bergmann
2021-12-01 13:43 ` Vladimir Murzin
2021-12-01 14:05 ` Arnd Bergmann [this message]
2021-12-01 14:15 ` Vladimir Murzin
2021-12-01 15:13 ` Arnd Bergmann
2021-12-01 15:51 ` Vladimir Murzin
2021-12-02 8:35 ` Ard Biesheuvel
2021-12-02 9:05 ` Marc Zyngier
2021-12-02 9:23 ` Arnd Bergmann
2021-12-02 9:33 ` Vladimir Murzin
2021-12-02 9:45 ` Arnd Bergmann
2021-12-02 11:05 ` Ard Biesheuvel
2021-12-02 14:12 ` Vladimir Murzin
2021-12-02 16:46 ` Ard Biesheuvel
2021-12-02 18:02 ` Vladimir Murzin
2021-12-02 18:38 ` Ard Biesheuvel
2021-12-02 20:27 ` Jesse Taube
2021-12-02 9:31 ` Marc Zyngier
2021-12-02 9:32 ` [irqchip: irq/irqchip-fixes] irqchip: nvic: Fix offset for Interrupt Priority Offsets irqchip-bot for Vladimir Murzin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a1fe8L7FpsRCgA8f26GzhDUW5NZqvFkQH=fx_PigJmrrg@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=ardb@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=vladimir.murzin@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.