Re: [PATCH] Input: adp5588-keys: Remove unused driver

From: Arnd Bergmann <arnd@arndb.de>
To: "Hennerich, Michael" <Michael.Hennerich@analog.com>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"Arnd Bergmann" <arnd@arndb.de>, "Sa, Nuno" <Nuno.Sa@analog.com>,
	"Bogdan, Dragos" <Dragos.Bogdan@analog.com>
Subject: Re: [PATCH] Input: adp5588-keys: Remove unused driver
Date: Thu, 5 May 2022 08:33:42 +0200	[thread overview]
Message-ID: <CAK8P3a2xnKMsdOeO=DF20rt=pT6zQvBvocqOUNwceXKzXFpSfw@mail.gmail.com> (raw)
In-Reply-To: <SJ0PR03MB6253FB12C55E309BA438BF918EC29@SJ0PR03MB6253.namprd03.prod.outlook.com>

On Thu, May 5, 2022 at 8:20 AM Hennerich, Michael
<Michael.Hennerich@analog.com> wrote:
> >
> > The last user is gone since 2018 (commit 4ba66a976072 ("arch: remove
> > blackfin port")). This is an i2c driver, so it could be used on a non-blackfin
> > machine, but this driver requires platform data, so it cannot be bound using
> > device tree.
>
> Hi Uwe,
>
> If we start removing drivers which obviously don't have a mainline in-tree user,
> we would upset up many users of these drivers.
> I agree on updating this driver to make platform data optional.
> We could provide a patch in a few days.
>
> Thoughts?

I think the absence of both a DT binding and platforms that define the
platform_data
is a good indication that there are exactly zero users, I wouldn't
worry about that
unless you know of specific users.

If it turns out that there are users on non-blackfin machines that still run on
modern kernels, you should work with them to make a proper DT binding and
drop the platform_data side of the driver.

        Arnd