Re: [PATCH v2 2/2] dt-bindings: trivial-devices: Add qca,qca4024

From: frut3k7 <frut3k7@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	Robert Marko <robimarko@gmail.com>,
	 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 Mark Brown <broonie@kernel.org>,
	Guenter Roeck <linux@roeck-us.net>,
	 Peter Yin <peteryin.openbmc@gmail.com>,
	 Patrick Rudolph <patrick.rudolph@9elements.com>,
	Michal Simek <michal.simek@amd.com>,  Marek Vasut <marex@denx.de>,
	Luca Ceresoli <luca.ceresoli@bootlin.com>,
	 Bjorn Helgaas <bhelgaas@google.com>,
	Lukas Wunner <lukas@wunner.de>, Fabio Estevam <festevam@denx.de>,
	 Alexander Stein <alexander.stein@ew.tq-group.com>,
	devicetree@vger.kernel.org,  linux-kernel@vger.kernel.org,
	linux-spi@vger.kernel.org
Subject: Re: [PATCH v2 2/2] dt-bindings: trivial-devices: Add qca,qca4024
Date: Thu, 15 Feb 2024 23:01:00 +0100	[thread overview]
Message-ID: <CAKEyCaAy9U_qQ=pXPYaGetEuuuVuoejxjKPrG92fBFauy1wwuw@mail.gmail.com> (raw)
In-Reply-To: <cd8c2f79-2307-4ad8-90c7-747d40f14ede@linaro.org>

The device I use has the QCA4024 chip connected via the spi controller:
        blsp1_spi4: spi@78b8000 {
            compatible = "qcom,spi-qup-v2.2.1";
            #address-cells = <1>;
            #size-cells = <0>;
            reg = <0x78b8000 0x600>;
            interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
            clocks = <&gcc GCC_BLSP1_QUP4_SPI_APPS_CLK>,
                 <&gcc GCC_BLSP1_AHB_CLK>;
            clock-names = "core", "iface";
            dmas = <&blsp_dma 18>, <&blsp_dma 19>;
            dma-names = "tx", "rx";
            status = "disabled";
        };

and apart from setting the frequency and gpio there is nothing else:
        &blsp1_spi4 {
            status = "okay";

            pinctrl-0 = <&spi_3_pins &quartz_pins>;
            pinctrl-names = "default";

            /* Qualcomm QCA4024 IoT */
            iot@3 {
                compatible = "qca,qca4024";
                reg = <0>;
                spi-max-frequency = <24000000>;
            };
        };

        &tlmm {
            spi_3_pins: spi-3-state {
                spi-pins {
                    pins = "gpio50", "gpio52", "gpio53";
                    function = "blsp3_spi";
                    drive-strength = <8>;
                    bias-disable;
                };

                cs-pins {
                    pins = "gpio22";
                    function = "blsp3_spi2";
                    drive-strength = <8>;
                    bias-disable;
                };
            };

            quartz_pins: quartz-state {
                interrupt-pins {
                    pins = "gpio48";
                    function = "gpio";
                    bias-disable;
                    input;
                };

                reset-pins {
                    pins = "gpio21";
                    function = "gpio";
                    bias-disable;
                    output-high;
                };
            };
        };

On Thu, Feb 8, 2024 at 8:32 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 07/02/2024 23:45, Paweł Owoc wrote:
> > Add Qualcomm QCA4024 to trivial devices.
> >
> > Signed-off-by: Paweł Owoc <frut3k7@gmail.com>
> > ---
> >  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> > index 79dcd92c4a43..c6362e981920 100644
> > --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> > @@ -309,6 +309,8 @@ properties:
> >            - plx,pex8648
> >              # Pulsedlight LIDAR range-finding sensor
> >            - pulsedlight,lidar-lite-v2
> > +            # Qualcomm QCA4024 Multi-mode Bluetooth and 802.15.4 SoC
> > +          - qca,qca4024
>
>
> As I wrote, Bluetooth chip is not a trivial device. This one
> particular exposes several interfaces to the host, needs a clock and
> power supply.
>
> Best regards,
> Krzysztof
>