Re: [PATCH RFC 06/24] drm/lima: add lima uapi header

From: Qiang Yu <yuq825@gmail.com>
To: Eric Anholt <eric@anholt.net>
Cc: Simon Shields <simon@lineageos.org>, Marek Vasut <marex@denx.de>,
	Connor Abbott <cwabbott0@gmail.com>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Andrei Paulau <7134956@gmail.com>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Vasily Khoruzhick <anarsoul@gmail.com>,
	Erico Nunes <nunes.erico@gmail.com>
Subject: Re: [PATCH RFC 06/24] drm/lima: add lima uapi header
Date: Tue, 22 May 2018 09:33:52 +0800	[thread overview]
Message-ID: <CAKGbVbsiFsgeWxjMvgr_2DBUo7R-nDq2nF5-08mWX9kMMsCssw@mail.gmail.com> (raw)
In-Reply-To: <871se4u6re.fsf@anholt.net>

On Tue, May 22, 2018 at 3:51 AM, Eric Anholt <eric@anholt.net> wrote:
> Qiang Yu <yuq825@gmail.com> writes:
>
>> Signed-off-by: Qiang Yu <yuq825@gmail.com>
>> ---
>>  include/uapi/drm/lima_drm.h | 195 ++++++++++++++++++++++++++++++++++++
>>  1 file changed, 195 insertions(+)
>>  create mode 100644 include/uapi/drm/lima_drm.h
>>
>> diff --git a/include/uapi/drm/lima_drm.h b/include/uapi/drm/lima_drm.h
>> new file mode 100644
>> index 000000000000..9df95e46fb2c
>> --- /dev/null
>> +++ b/include/uapi/drm/lima_drm.h
>> @@ -0,0 +1,195 @@
>> +/*
>> + * Copyright (C) 2017-2018 Lima Project
>
> Unless you've made some legal organization, your copyrights should
> probably be held by the individuals that wrote the code.
>
I just reference the etnaviv project here, not very clear about the
consequence of this.

>
> It would be nice to have some comments explaining the API being
> described here.  However, it does seem to follow our 32-vs-64 ABI rules,
> so it's in pretty good shape.

OK, I'll add more comments for the interface.

>
>> + *
>> + * Permission is hereby granted, free of charge, to any person obtaining a
>> + * copy of this software and associated documentation files (the "Software"),
>> + * to deal in the Software without restriction, including without limitation
>> + * the rights to use, copy, modify, merge, publish, distribute, sublicense,
>> + * and/or sell copies of the Software, and to permit persons to whom the
>> + * Software is furnished to do so, subject to the following conditions:
>> + *
>> + * The above copyright notice and this permission notice shall be included in
>> + * all copies or substantial portions of the Software.
>> + *
>> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
>> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
>> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
>> + * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
>> + * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
>> + * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
>> + * OTHER DEALINGS IN THE SOFTWARE.
>> + */
>
>> +
>> +#define LIMA_CTX_OP_CREATE 1
>> +#define LIMA_CTX_OP_FREE   2
>> +
>> +struct drm_lima_ctx {
>> +     __u32 op;          /* in */
>> +     __u32 id;          /* in/out */
>> +};
>
> I would recommend separate ioctls for these, given that the
> implementations are totally separate.
Also reference the amdgpu implementation which migrate ctx
related operation. May add more ops like ctx priority set.

Regards,
Qiang
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel