Re: [PATCH v4 4/4] avocado_qemu: Fix KNOWN_DISTROS map into the LinuxDistro class

From: Willian Rampazzo <wrampazz@redhat.com>
To: Eric Auger <eric.auger@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>, Peter Xu <peterx@redhat.com>,
	Wainer Moschetta <wainersm@redhat.com>,
	Cleber Rosa Junior <crosa@redhat.com>,
	Philippe Mathieu Daude <philmd@redhat.com>,
	eric.auger.pro@gmail.com
Subject: Re: [PATCH v4 4/4] avocado_qemu: Fix KNOWN_DISTROS map into the LinuxDistro class
Date: Mon, 5 Jul 2021 18:17:20 -0300	[thread overview]
Message-ID: <CAKJDGDbmkRNoruTwW80G=joJUyXoFQgxxQKgAj9MTpsSaQ=m_g@mail.gmail.com> (raw)
In-Reply-To: <20210629143621.907831-5-eric.auger@redhat.com>

On Tue, Jun 29, 2021 at 11:36 AM Eric Auger <eric.auger@redhat.com> wrote:
>
> From: Wainer dos Santos Moschetta <wainersm@redhat.com>
>
> As the KNOWN_DISTROS grows, more loosely methods will be created in
> the avocado_qemu/__init__.py file.
>
> Let's refactor the code so that KNOWN_DISTROS and related methods are
> packaged in a class
>
> Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
> Signed-off-by: Eric Auger <eric.auger@redhat.com>
>
> ---
>
> [Eric] rebase and add commit message
> ---
>  tests/acceptance/avocado_qemu/__init__.py | 160 +++++++++++-----------
>  tests/acceptance/intel_iommu.py           |  12 +-
>  tests/acceptance/smmu.py                  |  12 +-
>  3 files changed, 94 insertions(+), 90 deletions(-)
>

As suggested in the cover letter, moving the changes from Wainer to
the beginning of the patches makes more sense and reduces the amount
of changes.

The code refactoring from Wainer is here:
https://gitlab.com/willianrampazzo/qemu/-/commits/test_eric_auger_v5