From: Daniel Vetter <daniel@ffwll.ch>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [RFC][PATCH 4/4] drm: i915: Atomic pageflip WIP
Date: Fri, 14 Sep 2012 17:39:30 +0200 [thread overview]
Message-ID: <CAKMK7uFdLqqRLof14t3mBw+BUukyYUEcTd9_M10m446-xrBRkQ@mail.gmail.com> (raw)
In-Reply-To: <20120914153021.GF19732@intel.com>
On Fri, Sep 14, 2012 at 5:30 PM, Ville Syrjälä
<ville.syrjala@linux.intel.com> wrote:
> intel_pipe_set_base() won't disable the pipe or change the size,
> it'll just flip the primary plane. So that doesn't quite explain
> why the call is there, as opposed to being called just from the
> full modeset path.
intel_pipe_set_base is also called in the modeset case, i.e. when we
could potentially change the height of the mode. And if we wait on a
large enough scanline which doesn't exist in the new mode this would
hang.
The other callsite of finish_fb is from intel_crtc_disable.
btw, some slight digging around with git blame gives you in both cases
the commits and comments that explain this all ;-)
Cheers, Daniel
--
Daniel Vetter
daniel.vetter@ffwll.ch - +41 (0) 79 364 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2012-09-14 15:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-12 15:47 [RFC][PATCH] Atomic page flip WIP ville.syrjala
2012-09-12 15:47 ` [RFC][PATCH 1/4] drm/i915: Try to commit single pipe in one go ville.syrjala
2012-09-12 15:47 ` [RFC][PATCH 2/4] drm: Add drm_flip helper ville.syrjala
2012-09-12 15:47 ` [RFC][PATCH 3/4] drm: i915: Pass gem object to intel_finish_fb() ville.syrjala
2012-09-12 15:47 ` [RFC][PATCH 4/4] drm: i915: Atomic pageflip WIP ville.syrjala
2012-09-14 13:57 ` Chris Wilson
2012-09-14 14:21 ` Ville Syrjälä
2012-09-14 14:27 ` Chris Wilson
2012-09-14 15:30 ` Ville Syrjälä
2012-09-14 15:39 ` Daniel Vetter [this message]
2012-09-14 15:52 ` Ville Syrjälä
2012-09-14 15:56 ` Chris Wilson
2012-09-14 16:07 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKMK7uFdLqqRLof14t3mBw+BUukyYUEcTd9_M10m446-xrBRkQ@mail.gmail.com \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.