Re: [PATCH 02/10] drm/doc: integrate drm_crtc.c kerneldoc

From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 02/10] drm/doc: integrate drm_crtc.c kerneldoc
Date: Thu, 20 Dec 2012 11:14:33 +0100	[thread overview]
Message-ID: <CAKMK7uGKBVV+OP0eaXpJsT=5ZaswFmcZnbg1qhr+oq+MZnL44g@mail.gmail.com> (raw)
In-Reply-To: <20121219181925.GA29018@intel.com>

On Wed, Dec 19, 2012 at 7:19 PM, Ville Syrjälä
<ville.syrjala@linux.intel.com> wrote:
> On Tue, Dec 18, 2012 at 10:25:05PM +0100, Daniel Vetter wrote:
>> And do a quick pass to adjust them to the last few (years?) of changes
>> ...
>>
>> This time actually compile-tested ;-)
>>
>> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>> ---
>>  Documentation/DocBook/drm.tmpl |    4 ++
>>  drivers/gpu/drm/drm_crtc.c     |   92 +++++++++++++++++++---------------------
>>  2 files changed, 48 insertions(+), 48 deletions(-)
>>
>> diff --git a/Documentation/DocBook/drm.tmpl b/Documentation/DocBook/drm.tmpl
>> index 4ee2304..caab791 100644
>> --- a/Documentation/DocBook/drm.tmpl
>> +++ b/Documentation/DocBook/drm.tmpl
> <snip>
>> @@ -321,6 +326,7 @@ EXPORT_SYMBOL(drm_framebuffer_unreference);
>>
>>  /**
>>   * drm_framebuffer_reference - incr the fb refcnt
>
> Maybe improve the comment here while you're at it. The function name is
> more verbose/readable than the comment :)

Imo better to make a pass over all the kerneldoc after the locking
rework has landed - the patches change it quite a lot ;-)
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch