Re: [i-g-t][PATCH 0/2] Test for page flip hangs

From: Daniel Vetter <daniel@ffwll.ch>
To: ville.syrjala@linux.intel.com
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [i-g-t][PATCH 0/2] Test for page flip hangs
Date: Wed, 30 Jan 2013 16:06:01 +0100	[thread overview]
Message-ID: <CAKMK7uHn1DiKkXisA2igZeLZV-rLSKLbK9c1Xg9u4r0cTaTzmg@mail.gmail.com> (raw)
In-Reply-To: <1359550344-14761-1-git-send-email-ville.syrjala@linux.intel.com>

On Wed, Jan 30, 2013 at 02:52:22PM +0200, ville.syrjala@linux.intel.com wrote:
> Here's a test to go along with the
> '[PATCH 0/6] drm/i915: Avoid stuck page flip waiters on GPU reset'
> kernel patches.

Very nice! I think for further mayhem around gpu hangs we could hang_gpu
function into the drmtest library.

> I'm not sure if this should really be in kms_flip since people might
> actually run that and not expect their machine to be useless
> afterwards. But kms_flip since it had most of the stuff I need anyway
> (fbs, flips, modeset) I just added it there.

I don't have any issues with i-g-t's killing the kernel, that's kinda the
point ;-) And with the subtest infrastructure there's also no big issue
with adding tons of different cases to the same binary imo.

For modeset test we might want to add some common filtering though to e.g.
only test a given connector type. Otoh a single test usually runs down
rather quickly.

I've gone right ahead and merged the tests.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch