Re: [PATCH 1/2] acpi: Make TPM version configurable.

From: Jason Andryuk <jandryuk@gmail.com>
To: Jennifer Herbert <jennifer.herbert@citrix.com>
Cc: jbeulich@suse.com, andrew.cooper3@citrix.com, wl@xen.org,
	 roger.pau@citrix.com, xen-devel@lists.xenproject.org
Subject: Re: [PATCH 1/2] acpi: Make TPM version configurable.
Date: Mon, 19 Sep 2022 13:18:39 -0400	[thread overview]
Message-ID: <CAKf6xpt04v52fzq7v4RC8XFJcfT8Hit-tnCTaBZ0w5mv8F0kbg@mail.gmail.com> (raw)
In-Reply-To: <20220915204029.1227112-1-jennifer.herbert@citrix.com>

On Thu, Sep 15, 2022 at 4:41 PM Jennifer Herbert
<jennifer.herbert@citrix.com> wrote:
>
> This patch makes the TPM version, for which the ACPI libary probes, configurable.
> If acpi_config.tpm_verison is set to 1, it indicates that 1.2 (TCPA) should be probed.
> I have also added to hvmloader an option to allow setting this new config, which can
> be triggered by setting the platform/tpm_verion xenstore key.
>
> Signed-off-by: Jennifer Herbert <jennifer.herbert@citrix.com>
> ---
>  docs/misc/xenstore-paths.pandoc |  8 ++++
>  tools/firmware/hvmloader/util.c | 13 ++++++-
>  tools/libacpi/build.c           | 68 ++++++++++++++++++---------------
>  tools/libacpi/libacpi.h         |  4 +-
>  4 files changed, 59 insertions(+), 34 deletions(-)
>
> diff --git a/docs/misc/xenstore-paths.pandoc b/docs/misc/xenstore-paths.pandoc
> index 5cd5c8a3b9..7270b46721 100644
> --- a/docs/misc/xenstore-paths.pandoc
> +++ b/docs/misc/xenstore-paths.pandoc
> @@ -269,6 +269,14 @@ at the guest physical address in HVM_PARAM_VM_GENERATION_ID_ADDR.
>  See Microsoft's "Virtual Machine Generation ID" specification for the
>  circumstances where the generation ID needs to be changed.
>
> +
> +#### ~/platform/tpm_version = INTEGER [HVM,INTERNAL]
> +
> +The TPM version to be probed for.
> +
> +A value of 1 indicates to probe for TPM 1.2. If unset, or an
> +invalid version, then no TPM is probed.
> +

Hi,

In patch 2, I think you want to expand this section for TPM 2.0 support.

Regards,
Jason