Re: [PATCH] xsm: removing inclusion of byteorder.h

From: Jason Andryuk <jandryuk@gmail.com>
To: "Daniel P. Smith" <dpsmith@apertussolutions.com>
Cc: xen-devel@lists.xenproject.org
Subject: Re: [PATCH] xsm: removing inclusion of byteorder.h
Date: Thu, 17 Aug 2023 08:17:42 -0400	[thread overview]
Message-ID: <CAKf6xpvpHq5vBHm20snGr+fgu78Kviiwne2JVcxrESXStDs2Mw@mail.gmail.com> (raw)
In-Reply-To: <20230816190425.8160-1-dpsmith@apertussolutions.com>

On Wed, Aug 16, 2023 at 3:05 PM Daniel P. Smith
<dpsmith@apertussolutions.com> wrote:
>
> This is to complement patch 'common: move Linux-inherited fixed width type
> decls to common header' by removing the unnecessary include of
> 'asm/byteorder.h'. In the process of removing these includes, the ordering was
> corrected to comply with current coding style.
>
> Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
> ---
>  xen/xsm/flask/ss/avtab.c       | 3 +--
>  xen/xsm/flask/ss/conditional.c | 9 ++++-----
>  xen/xsm/flask/ss/ebitmap.c     | 8 ++++----
>  xen/xsm/flask/ss/policydb.c    | 9 ++++-----
>  4 files changed, 13 insertions(+), 16 deletions(-)

These four files all call le32_to_cpu(), so AFAICT, you are trading an
explicit dependency for an implicit one.  Is that what you want?

Regards,
Jason