From: Lucas De Marchi <lucas.de.marchi@gmail.com>
To: Manasi Navare <manasi.d.navare@intel.com>
Cc: Intel Graphics <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915/dp: Fix DSC enable code to use cpu_transcoder instead of encoder->type
Date: Fri, 23 Aug 2019 01:28:44 -0700 [thread overview]
Message-ID: <CAKi4VA+iNW8Kx1hCePsFUGeUGTQubbf=B_pTJ=FVCYGoboO3wQ@mail.gmail.com> (raw)
In-Reply-To: <20190821215950.24223-1-manasi.d.navare@intel.com>
On Thu, Aug 22, 2019 at 7:20 AM Manasi Navare <manasi.d.navare@intel.com> wrote:
>
> This patch fixes the intel_configure_pps_for_dsc_encoder() function to use
> cpu_transcoder instead of encoder->type to select the correct DSC registers
> that was wrongly used in the original patch for one DSC register isntance.
>
> Fixes: 7182414e2530 ("drm/i915/dp: Configure i915 Picture parameter Set
> registers during DSC enabling")
> Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_vdsc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_vdsc.c b/drivers/gpu/drm/i915/display/intel_vdsc.c
> index 598ddb60f9fb..d4fb7f16f9f6 100644
> --- a/drivers/gpu/drm/i915/display/intel_vdsc.c
> +++ b/drivers/gpu/drm/i915/display/intel_vdsc.c
> @@ -547,7 +547,7 @@ static void intel_configure_pps_for_dsc_encoder(struct intel_encoder *encoder,
> pps_val |= DSC_PIC_HEIGHT(vdsc_cfg->pic_height) |
> DSC_PIC_WIDTH(vdsc_cfg->pic_width / num_vdsc_instances);
> DRM_INFO("PPS2 = 0x%08x\n", pps_val);
> - if (encoder->type == INTEL_OUTPUT_EDP) {
> + if (cpu_transcoder == TRANSCODER_EDP) {
This will break tiger lake as there is no TRANSCODER_EDP there.
Lucas De Marchi
> I915_WRITE(DSCA_PICTURE_PARAMETER_SET_2, pps_val);
> /*
> * If 2 VDSC instances are needed, configure PPS for second
> --
> 2.19.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Lucas De Marchi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2019-08-23 8:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 21:59 [PATCH] drm/i915/dp: Fix DSC enable code to use cpu_transcoder instead of encoder->type Manasi Navare
2019-08-22 10:18 ` Maarten Lankhorst
2019-08-22 15:21 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-08-22 21:17 ` [PATCH] " Manasi Navare
2019-08-23 7:59 ` ✓ Fi.CI.IGT: success for " Patchwork
2019-08-23 8:28 ` Lucas De Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKi4VA+iNW8Kx1hCePsFUGeUGTQubbf=B_pTJ=FVCYGoboO3wQ@mail.gmail.com' \
--to=lucas.de.marchi@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=manasi.d.navare@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.