Re: [Intel-gfx] [PATCH] drm/i915/dsb: Increase log level if DSB engine gets busy

From: Lucas De Marchi <lucas.de.marchi@gmail.com>
To: Swati Sharma <swati2.sharma@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>,
	Intel Graphics <intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/dsb: Increase log level if DSB engine gets busy
Date: Thu, 26 Dec 2019 13:09:49 -0800	[thread overview]
Message-ID: <CAKi4VAJOsg5pashSkEjTd4LrrbZ3ZXwK8ivw1PEfQbBrW5gWKA@mail.gmail.com> (raw)
In-Reply-To: <20191225175514.21271-1-swati2.sharma@intel.com>

On Wed, Dec 25, 2019 at 10:07 AM Swati Sharma <swati2.sharma@intel.com> wrote:
>
> Increase the log level if DSB engine gets busy. If dsb engine
> is busy, it should be an error condition to indicate there might be
> some difficulty with the hardware.
>
> If DSB engine gets busy, load luts will fail and as per current
> driver design if one instance of DSB engine gets busy, we are not
> allocating the other instance. So, increase the log level to indicate there
> could be an issue with driver/hardware.
>
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_dsb.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c
> index ada006a690df..6f67b5dfa128 100644
> --- a/drivers/gpu/drm/i915/display/intel_dsb.c
> +++ b/drivers/gpu/drm/i915/display/intel_dsb.c
> @@ -52,7 +52,7 @@ static inline bool intel_dsb_enable_engine(struct intel_dsb *dsb)
>
>         dsb_ctrl = I915_READ(DSB_CTRL(pipe, dsb->id));
>         if (DSB_STATUS & dsb_ctrl) {
> -               DRM_DEBUG_KMS("DSB engine is busy.\n");
> +               DRM_ERROR("DSB engine is busy.\n");

are we seeing this? Isn't it a dbg message because in this case we
would fallback to direct mmio?

Lucas De Marchi

>                 return false;
>         }
>
> @@ -72,7 +72,7 @@ static inline bool intel_dsb_disable_engine(struct intel_dsb *dsb)
>
>         dsb_ctrl = I915_READ(DSB_CTRL(pipe, dsb->id));
>         if (DSB_STATUS & dsb_ctrl) {
> -               DRM_DEBUG_KMS("DSB engine is busy.\n");
> +               DRM_ERROR("DSB engine is busy.\n");
>                 return false;
>         }
>
> --
> 2.24.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Lucas De Marchi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx