Re: [PATCH v2 0/3] fio: add xnvme engine

From: Ankit Kumar <ankit1455@gmail.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Ankit Kumar <ankit.kumar@samsung.com>,
	fio@vger.kernel.org, krish.reddy@samsung.com,
	simon.lund@samsung.com, joshiiitr@gmail.com,
	anuj1072538@gmail.com
Subject: Re: [PATCH v2 0/3] fio: add xnvme engine
Date: Fri, 13 May 2022 16:36:16 +0530	[thread overview]
Message-ID: <CAKi7+weGb3AsfGKkHEiPNFDxQEKTDn68nb6cbfJNzM=+p+=3LA@mail.gmail.com> (raw)
In-Reply-To: <cf9dbc97-0847-6887-3d8f-320432bf5176@kernel.dk>

Thanks a lot for applying the xnvme engine changes. Yes we are adding
passthrough support in io_uring by having a separate ioengine_ops. The
changes will be ready shortly.

On Thu, May 12, 2022 at 5:58 PM Jens Axboe <axboe@kernel.dk> wrote:
>
> On 5/12/22 12:28 AM, Ankit Kumar wrote:
> > Yes we are using xnvme on various platforms, and it would be great if
> > it gets included as part of FIO.
> > For supporting io_uring engine with passthrough, yes we also have a
> > plan in place to clean up the code and send it for review.
>
> Sounds good. I've applied the xvnme engine, would appreciate if we can
> do the passthrough one shortly too. I'm wondering if that one is best
> done as a separate engine too - it could still be in engines/io_uring.c
> but have a separate ioengine_ops to keep the code nicely separated while
> still being able to use the same helpers in there.
>
> --
> Jens Axboe
>