From: Alistair Francis <alistair23@gmail.com>
To: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Cc: figlesia@xilinx.com, "Peter Maydell" <peter.maydell@linaro.org>,
"Edgar Iglesias" <edgar.iglesias@xilinx.com>,
"Sai Pavan Boddu" <sai.pavan.boddu@xilinx.com>,
"Francisco Iglesias" <frasse.iglesias@gmail.com>,
"Alistair Francis" <alistair@alistair23.me>,
"Richard Henderson" <richard.henderson@linaro.org>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
"KONRAD Frederic" <frederic.konrad@adacore.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Luc Michel" <luc.michel@greensocs.com>
Subject: Re: [PATCH v1 2/3] target/microblaze: Plug temp leaks with delay slot setup
Date: Wed, 6 Nov 2019 13:56:53 -0800 [thread overview]
Message-ID: <CAKmqyKPypCij5EKvyxDJcasn8tibqoCt_ovn2C52kUskmC=C5g@mail.gmail.com> (raw)
In-Reply-To: <20191106141424.27244-3-edgar.iglesias@gmail.com>
On Wed, Nov 6, 2019 at 6:17 AM Edgar E. Iglesias
<edgar.iglesias@gmail.com> wrote:
>
> From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
>
> Plug temp leaks with delay slot setup.
>
> Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> target/microblaze/translate.c | 26 ++++++++++++++------------
> 1 file changed, 14 insertions(+), 12 deletions(-)
>
> diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c
> index ba143ede5f..e9ff9e650d 100644
> --- a/target/microblaze/translate.c
> +++ b/target/microblaze/translate.c
> @@ -1201,6 +1201,17 @@ static void eval_cond_jmp(DisasContext *dc, TCGv_i64 pc_true, TCGv_i64 pc_false)
> tcg_temp_free_i64(tmp_zero);
> }
>
> +static void dec_setup_dslot(DisasContext *dc)
> +{
> + TCGv_i32 tmp = tcg_const_i32(dc->type_b && (dc->tb_flags & IMM_FLAG));
> +
> + dc->delayed_branch = 2;
> + dc->tb_flags |= D_FLAG;
> +
> + tcg_gen_st_i32(tmp, cpu_env, offsetof(CPUMBState, bimm));
> + tcg_temp_free_i32(tmp);
> +}
> +
> static void dec_bcc(DisasContext *dc)
> {
> unsigned int cc;
> @@ -1212,10 +1223,7 @@ static void dec_bcc(DisasContext *dc)
>
> dc->delayed_branch = 1;
> if (dslot) {
> - dc->delayed_branch = 2;
> - dc->tb_flags |= D_FLAG;
> - tcg_gen_st_i32(tcg_const_i32(dc->type_b && (dc->tb_flags & IMM_FLAG)),
> - cpu_env, offsetof(CPUMBState, bimm));
> + dec_setup_dslot(dc);
> }
>
> if (dec_alu_op_b_is_small_imm(dc)) {
> @@ -1274,10 +1282,7 @@ static void dec_br(DisasContext *dc)
>
> dc->delayed_branch = 1;
> if (dslot) {
> - dc->delayed_branch = 2;
> - dc->tb_flags |= D_FLAG;
> - tcg_gen_st_i32(tcg_const_i32(dc->type_b && (dc->tb_flags & IMM_FLAG)),
> - cpu_env, offsetof(CPUMBState, bimm));
> + dec_setup_dslot(dc);
> }
> if (link && dc->rd)
> tcg_gen_movi_i32(cpu_R[dc->rd], dc->pc);
> @@ -1379,10 +1384,7 @@ static void dec_rts(DisasContext *dc)
> return;
> }
>
> - dc->delayed_branch = 2;
> - dc->tb_flags |= D_FLAG;
> - tcg_gen_st_i32(tcg_const_i32(dc->type_b && (dc->tb_flags & IMM_FLAG)),
> - cpu_env, offsetof(CPUMBState, bimm));
> + dec_setup_dslot(dc);
>
> if (i_bit) {
> LOG_DIS("rtid ir=%x\n", dc->ir);
> --
> 2.20.1
>
>
next prev parent reply other threads:[~2019-11-06 22:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 14:14 [PATCH v1 0/3] target/microblaze: Plug tcg temp leaks Edgar E. Iglesias
2019-11-06 14:14 ` [PATCH v1 1/3] target/microblaze: Plug temp leaks for loads/stores Edgar E. Iglesias
2019-11-06 14:32 ` Philippe Mathieu-Daudé
2019-11-06 14:37 ` Luc Michel
2019-11-06 21:55 ` Alistair Francis
2019-11-07 14:19 ` Richard Henderson
2019-11-08 12:36 ` Edgar E. Iglesias
2019-11-06 14:14 ` [PATCH v1 2/3] target/microblaze: Plug temp leaks with delay slot setup Edgar E. Iglesias
2019-11-06 14:33 ` Philippe Mathieu-Daudé
2019-11-06 14:41 ` Luc Michel
2019-11-06 21:56 ` Alistair Francis [this message]
2019-11-07 14:21 ` Richard Henderson
2019-11-06 14:14 ` [PATCH v1 3/3] target/microblaze: Plug temp leak around eval_cond_jmp() Edgar E. Iglesias
2019-11-06 14:32 ` Philippe Mathieu-Daudé
2019-11-06 14:42 ` Luc Michel
2019-11-06 21:57 ` Alistair Francis
2019-11-07 14:22 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKmqyKPypCij5EKvyxDJcasn8tibqoCt_ovn2C52kUskmC=C5g@mail.gmail.com' \
--to=alistair23@gmail.com \
--cc=alistair@alistair23.me \
--cc=edgar.iglesias@gmail.com \
--cc=edgar.iglesias@xilinx.com \
--cc=figlesia@xilinx.com \
--cc=frasse.iglesias@gmail.com \
--cc=frederic.konrad@adacore.com \
--cc=luc.michel@greensocs.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=sai.pavan.boddu@xilinx.com \
--cc=sstabellini@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.