From: Ard Biesheuvel <ardb@kernel.org>
To: Arvind Sankar <nivedita@alum.mit.edu>
Cc: linux-efi <linux-efi@vger.kernel.org>,
"the arch/x86 maintainers" <x86@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/5] efi/x86: Add kernel preferred address to PE header
Date: Tue, 3 Mar 2020 20:11:34 +0100 [thread overview]
Message-ID: <CAKv+Gu_Xbw7SjdCvHMrDXW4o-XtM8FH4LAXPtro9cXSecVuFSA@mail.gmail.com> (raw)
In-Reply-To: <20200301230537.2247550-4-nivedita@alum.mit.edu>
On Mon, 2 Mar 2020 at 00:05, Arvind Sankar <nivedita@alum.mit.edu> wrote:
>
> Store the kernel's link address as ImageBase in the PE header. Note that
> the PE specification requires the ImageBase to be 64k aligned. The
> preferred address should almost always satisfy that, except for 32-bit
> kernel if the configuration has been customized.
>
> Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu>
> ---
> arch/x86/boot/header.S | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/boot/header.S b/arch/x86/boot/header.S
> index 4ee25e28996f..0d8d2cb28fd9 100644
> --- a/arch/x86/boot/header.S
> +++ b/arch/x86/boot/header.S
> @@ -138,10 +138,12 @@ optional_header:
> #endif
>
> extra_header_fields:
> + # PE specification requires ImageBase to be 64k-aligned
> + .set ImageBase, (LOAD_PHYSICAL_ADDR+0xffff) & ~0xffff
Could you call this image_base please, and put some spaces around the +
> #ifdef CONFIG_X86_32
> - .long 0 # ImageBase
> + .long ImageBase # ImageBase
> #else
> - .quad 0 # ImageBase
> + .quad ImageBase # ImageBase
> #endif
> .long 0x20 # SectionAlignment
> .long 0x20 # FileAlignment
> --
> 2.24.1
>
next prev parent reply other threads:[~2020-03-03 19:11 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-01 23:05 [PATCH 0/5] Minimize the need to move the kernel in the EFI stub Arvind Sankar
2020-03-01 23:05 ` [PATCH 1/5] x86/boot/compressed/32: Save the output address instead of recalculating it Arvind Sankar
2020-03-03 19:10 ` Ard Biesheuvel
2020-03-01 23:05 ` [PATCH 2/5] efi/x86: Decompress at start of PE image load address Arvind Sankar
2020-03-03 6:28 ` Mika Penttilä
2020-03-03 13:45 ` Arvind Sankar
2020-03-03 19:08 ` Ard Biesheuvel
2020-03-01 23:05 ` [PATCH 3/5] efi/x86: Add kernel preferred address to PE header Arvind Sankar
2020-03-03 19:11 ` Ard Biesheuvel [this message]
2020-03-01 23:05 ` [PATCH 4/5] efi/x86: Remove extra headroom for setup block Arvind Sankar
2020-03-02 4:21 ` Mika Penttilä
2020-03-03 4:14 ` Arvind Sankar
2020-03-01 23:05 ` [PATCH 5/5] efi/x86: Don't relocate the kernel unless necessary Arvind Sankar
2020-03-03 19:15 ` Ard Biesheuvel
2020-03-03 22:12 ` [PATCH v2 0/5] Minimize the need to move the kernel in the EFI stub Arvind Sankar
2020-03-03 22:12 ` [PATCH v2 1/5] x86/boot/compressed/32: Save the output address instead of recalculating it Arvind Sankar
2020-03-03 22:12 ` [PATCH v2 2/5] efi/x86: Decompress at start of PE image load address Arvind Sankar
2020-03-03 22:12 ` [PATCH v2 3/5] efi/x86: Add kernel preferred address to PE header Arvind Sankar
2020-03-03 22:12 ` [PATCH v2 4/5] efi/x86: Remove extra headroom for setup block Arvind Sankar
2020-05-11 17:01 ` Mike Lothian
2020-05-11 18:36 ` Arvind Sankar
2020-05-11 21:13 ` Ard Biesheuvel
2020-05-11 22:53 ` Arvind Sankar
2020-05-11 22:58 ` [PATCH] x86/boot: Mark global variables as static Arvind Sankar
2020-05-11 23:12 ` Mike Lothian
2020-05-12 11:05 ` Ard Biesheuvel
2020-05-22 18:30 ` [tip: efi/urgent] " tip-bot2 for Arvind Sankar
2020-03-03 22:12 ` [PATCH v2 5/5] efi/x86: Don't relocate the kernel unless necessary Arvind Sankar
2020-03-03 23:08 ` Ard Biesheuvel
2020-03-03 23:34 ` Arvind Sankar
2020-03-04 7:30 ` Ard Biesheuvel
2020-03-03 22:26 ` [PATCH v2 0/5] Minimize the need to move the kernel in the EFI stub Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu_Xbw7SjdCvHMrDXW4o-XtM8FH4LAXPtro9cXSecVuFSA@mail.gmail.com \
--to=ardb@kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nivedita@alum.mit.edu \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.