From: Nick Desaulniers <ndesaulniers@google.com>
To: Li Zetao <lizetao1@huawei.com>
Cc: keescook@chromium.org, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org,
hpa@zytor.com, kirill.shutemov@linux.intel.com,
tony.luck@intel.com, masahiroy@kernel.org, michael.roth@amd.com,
sathyanarayanan.kuppuswamy@linux.intel.com, nathan@kernel.org,
brijesh.singh@amd.com, peterz@infradead.org,
venu.busireddy@oracle.com, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org
Subject: Re: [PATCH -next v4 1/2] x86/boot: Remove unused variables
Date: Tue, 11 Oct 2022 14:22:18 -0700 [thread overview]
Message-ID: <CAKwvOd=ASXzYmQzSVwa+e8X=H-pouPd8Owv14iHaAxjmMT+3tQ@mail.gmail.com> (raw)
In-Reply-To: <20221011012904.2330473-2-lizetao1@huawei.com>
On Mon, Oct 10, 2022 at 6:32 PM Li Zetao <lizetao1@huawei.com> wrote:
>
> diff --git a/arch/x86/boot/compressed/sev.c b/arch/x86/boot/compressed/sev.c
> index c93930d5ccbd..b9451761a69a 100644
> --- a/arch/x86/boot/compressed/sev.c
> +++ b/arch/x86/boot/compressed/sev.c
> @@ -253,7 +253,6 @@ void do_boot_stage2_vc(struct pt_regs *regs, unsigned long exit_code)
> static void enforce_vmpl0(void)
> {
> u64 attrs;
> - int err;
Just a thought but you could initialize attrs now on the same line.
I also ended up testing the whole series, so:
Tested-by: Nick Desaulniers <ndesaulniers@google.com>
--
Thanks,
~Nick Desaulniers
next prev parent reply other threads:[~2022-10-11 21:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 8:15 [PATCH -next v2 0/2] Remove unused variables in x86/boot Li Zetao
2022-09-27 8:15 ` [PATCH -next v2 1/2] x86/boot/compressed: Add "-Wall" flag to Makefile Li Zetao
2022-09-27 8:15 ` [PATCH -next v2 2/2] x86/boot: Remove unused variables Li Zetao
2022-09-27 21:50 ` [PATCH -next v2 0/2] Remove unused variables in x86/boot Nathan Chancellor
2022-09-27 21:58 ` Nathan Chancellor
2022-09-29 2:16 ` Li Zetao
2022-09-29 16:59 ` Nathan Chancellor
2022-09-30 3:27 ` [PATCH -next v3 " Li Zetao
2022-09-30 3:27 ` [PATCH -next v3 1/2] x86/boot/compressed: Add "-Wall" flag to Makefile Li Zetao
2022-09-30 3:27 ` [PATCH -next v3 2/2] x86/boot: Remove unused variables Li Zetao
2022-10-08 13:41 ` Ping: [PATCH -next v3 0/2] Remove unused variables in x86/boot Li Zetao
2022-10-09 15:17 ` Kees Cook
2022-10-11 1:29 ` [PATCH -next v4 " Li Zetao
2022-10-11 1:29 ` [PATCH -next v4 1/2] x86/boot: Remove unused variables Li Zetao
2022-10-11 21:15 ` Nick Desaulniers
2022-10-11 21:22 ` Nick Desaulniers [this message]
2022-10-11 1:29 ` [PATCH -next v4 2/2] x86/boot/compressed: Add "-Wall" flag to Makefile Li Zetao
2022-10-11 21:20 ` Nick Desaulniers
2022-10-17 17:01 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKwvOd=ASXzYmQzSVwa+e8X=H-pouPd8Owv14iHaAxjmMT+3tQ@mail.gmail.com' \
--to=ndesaulniers@google.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=brijesh.singh@amd.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizetao1@huawei.com \
--cc=masahiroy@kernel.org \
--cc=michael.roth@amd.com \
--cc=mingo@redhat.com \
--cc=nathan@kernel.org \
--cc=peterz@infradead.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=venu.busireddy@oracle.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.