From: Nick Desaulniers <ndesaulniers@google.com>
To: Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: linux-mips@vger.kernel.org, llvm@lists.linux.dev,
tsbogend@alpha.franken.de, nathan@kernel.org
Subject: Re: [PATCH 2/5] MIPS: Add toolchain feature dependency for microMIPS smartMIPS
Date: Fri, 7 Apr 2023 15:08:36 -0700 [thread overview]
Message-ID: <CAKwvOdn3DC=6nCW2Fj9A2RcEa-AHTYNveBzvLTxp7yh7N=AxgQ@mail.gmail.com> (raw)
In-Reply-To: <20230407102721.14814-3-jiaxun.yang@flygoat.com>
On Fri, Apr 7, 2023 at 3:27 AM Jiaxun Yang <jiaxun.yang@flygoat.com> wrote:
>
> microMIPS smartMIPS kernel can only be compiled if they are supported
> by toolchain.
>
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> ---
> arch/mips/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index c52401c155a4..9e9de2b62f28 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -2360,7 +2360,7 @@ config CPU_NEEDS_NO_SMARTMIPS_OR_MICROMIPS
> Select this if you want neither microMIPS nor SmartMIPS support
>
> config CPU_HAS_SMARTMIPS
> - depends on SYS_SUPPORTS_SMARTMIPS
> + depends on SYS_SUPPORTS_SMARTMIPS && CC_HAS_SMARTMIPS
> bool "SmartMIPS"
> help
> SmartMIPS is a extension of the MIPS32 architecture aimed at
> @@ -2372,7 +2372,7 @@ config CPU_HAS_SMARTMIPS
> here.
>
> config CPU_MICROMIPS
> - depends on 32BIT && SYS_SUPPORTS_MICROMIPS && !CPU_MIPSR6
> + depends on 32BIT && SYS_SUPPORTS_MICROMIPS && CC_HAS_MICROMIPS && !CPU_MIPSR6
^ greater than 80 chars (85 in total). Consider creating two "depends on" lines.
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
> bool "microMIPS"
> help
> When this option is enabled the kernel will be built using the
> --
> 2.39.2 (Apple Git-143)
>
--
Thanks,
~Nick Desaulniers
next prev parent reply other threads:[~2023-04-07 22:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-07 10:27 [PATCH 0/5] MIPS: LLVM toolchain support for more CPUs Jiaxun Yang
2023-04-07 10:27 ` [PATCH 1/5] MIPS: Move various toolchain ASE check to Kconfig Jiaxun Yang
2023-04-07 18:57 ` Nathan Chancellor
2023-04-07 22:51 ` Jiaxun Yang
2023-04-07 10:27 ` [PATCH 2/5] MIPS: Add toolchain feature dependency for microMIPS smartMIPS Jiaxun Yang
2023-04-07 22:08 ` Nick Desaulniers [this message]
2023-04-07 10:27 ` [PATCH 3/5] MIPS: Detect toolchain support of workarounds in Kconfig Jiaxun Yang
2023-04-07 22:15 ` Nick Desaulniers
2023-04-07 10:27 ` [PATCH 4/5] MIPS: Detect toolchain support of o32 ABI with 64 bit CPU Jiaxun Yang
2023-04-07 22:19 ` Nick Desaulniers
2023-04-07 22:21 ` Nick Desaulniers
2023-04-07 22:26 ` Jiaxun Yang
2023-04-07 10:27 ` [PATCH 5/5] MIPS: Fallback CPU -march CFLAG to ISA level if unsupported Jiaxun Yang
2023-04-07 22:23 ` Nick Desaulniers
2023-04-08 9:47 ` Jiaxun Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKwvOdn3DC=6nCW2Fj9A2RcEa-AHTYNveBzvLTxp7yh7N=AxgQ@mail.gmail.com' \
--to=ndesaulniers@google.com \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-mips@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.