From: Nick Desaulniers <ndesaulniers@google.com>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: "Gustavo A . R . Silva" <gustavoars@kernel.org>,
Joe Perches <joe@perches.com>,
Michal Marek <michal.lkml@markovi.net>,
Nathan Chancellor <natechancellor@gmail.com>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
clang-built-linux <clang-built-linux@googlegroups.com>
Subject: Re: [PATCH v2] Revert "kbuild: Do not enable -Wimplicit-fallthrough for clang for now"
Date: Sat, 7 Nov 2020 01:04:47 -0800 [thread overview]
Message-ID: <CAKwvOdnr94Pdt5GYGf52FHpa98ZtkwLWvAPiN_Se2qq9a+h_ag@mail.gmail.com> (raw)
In-Reply-To: <20201107084525.3417278-1-ndesaulniers@google.com>
On Sat, Nov 7, 2020 at 12:45 AM Nick Desaulniers
<ndesaulniers@google.com> wrote:
>
> This reverts commit e2079e93f562c7f7a030eb7642017ee5eabaaa10.
>
> This has been fixed up over time thanks to the addition of "fallthrough"
> pseudo-keyword in
> commit 294f69e662d1 ("compiler_attributes.h: Add 'fallthrough' pseudo
> keyword for switch/case use")
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/236
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
> ---
> Changes V1 -> V2:
> * We actually want a revert, not a partial revert. v1 removed
> -Wimplicit-fallthrough outright, which we don't want. We still need
> cc-option for GCC < 7.
Gah, I tested a ton of configs with V1...but not V2...this patch is
not ready yet. Sorry for the noise.
--
Thanks,
~Nick Desaulniers
next prev parent reply other threads:[~2020-11-07 9:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-07 7:07 [PATCH] Kbuild: enable -Wfallthrough for clang Nick Desaulniers
2020-11-07 8:07 ` Miguel Ojeda
2020-11-07 8:45 ` [PATCH v2] Revert "kbuild: Do not enable -Wimplicit-fallthrough for clang for now" Nick Desaulniers
2020-11-07 9:04 ` Nick Desaulniers [this message]
2020-11-09 9:33 ` kernel test robot
2020-11-09 9:33 ` kernel test robot
2020-11-09 10:42 ` kernel test robot
2020-11-09 10:42 ` kernel test robot
2020-11-07 11:17 ` [PATCH] Kbuild: enable -Wfallthrough for clang Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKwvOdnr94Pdt5GYGf52FHpa98ZtkwLWvAPiN_Se2qq9a+h_ag@mail.gmail.com \
--to=ndesaulniers@google.com \
--cc=clang-built-linux@googlegroups.com \
--cc=gustavoars@kernel.org \
--cc=joe@perches.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=natechancellor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.