Re: [PATCH] xfstests: add regression test for btrfs incremental send

From: Filipe David Manana <fdmanana@gmail.com>
To: Dave Chinner <david@fromorbit.com>
Cc: "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
	"xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests: add regression test for btrfs incremental send
Date: Mon, 17 Feb 2014 01:36:02 +0000	[thread overview]
Message-ID: <CAL3q7H4JLbMS+JL4h4du60S1vKFtvceP-Mx-e=0v4nTBwjkATA@mail.gmail.com> (raw)
In-Reply-To: <20140217011929.GA13997@dastard>

[-- Attachment #1.1: Type: text/plain, Size: 2118 bytes --]

On Monday, February 17, 2014, Dave Chinner <david@fromorbit.com> wrote:

> On Mon, Feb 17, 2014 at 12:20:38AM +0000, Filipe David Borba Manana wrote:
> > Test for a btrfs incremental send issue where we end up sending a
> > wrong section of data from a file extent if the corresponding file
> > extent is compressed and the respective file extent item has a non
> > zero data offset.
> >
> > Fixed by the following linux kernel btrfs patch:
> >
> >    Btrfs: use right clone root offset for compressed extents
> >
> > Signed-off-by: Filipe David Borba Manana <fdmanana@gmail.com<javascript:;>
> >
> > ---
> >
> > V2: Made the test more reliable. Now it doesn't depend anymore of btrfs'
> >     hole punch implementation leaving hole file extent items when we
> punch
> >     beyond the file's current size.
> > V3: Filter xfs_io output and make less use of the run_check function, as
> >     suggested by Dave Chinner.
>
> Awesome. Thanks for the quick turn around.
>
> >  common/rc           |    5 +++
> >  tests/btrfs/040     |  119
> +++++++++++++++++++++++++++++++++++++++++++++++++++
> >  tests/btrfs/040.out |    9 ++++
> >  tests/btrfs/group   |    1 +
> >  4 files changed, 134 insertions(+)
> >  create mode 100755 tests/btrfs/040
> >  create mode 100644 tests/btrfs/040.out
> >
> > diff --git a/common/rc b/common/rc
> > index e91568b..27be009 100644
> > --- a/common/rc
> > +++ b/common/rc
> > @@ -2207,6 +2207,11 @@ run_check()
> >       "$@" >> $seqres.full 2>&1 || _fail "failed: '$@'"
> >  }
> >
> > +_run_btrfs_util_prog()
> > +{
> > +     run_check $BTRFS_UTIL_PROG $*
> > +}
>
> Can you do a cleanup of all the other btrfs tests that can use this?

Ok. I just did that for all the test cases not yet merged, as you probably
noticed already.
For the ones already in the repository, I'll see if I can do it soon this
coming week.

Thanks

>
> Cheers,
>
> Dave.
> --
> Dave Chinner
> david@fromorbit.com <javascript:;>
>

-- 
Filipe David Manana,

"Reasonable men adapt themselves to the world.
 Unreasonable men adapt the world to themselves.
 That's why all progress depends on unreasonable men."

[-- Attachment #1.2: Type: text/html, Size: 3036 bytes --]

[-- Attachment #2: Type: text/plain, Size: 121 bytes --]

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs