Re: [PATCH 1/3] fstests: common: Use more accurate kernel config for _require_fail_make_request

From: Filipe Manana <fdmanana@gmail.com>
To: Qu Wenruo <wqu@suse.com>
Cc: fstests <fstests@vger.kernel.org>,
	linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 1/3] fstests: common: Use more accurate kernel config for _require_fail_make_request
Date: Tue, 17 Dec 2019 17:24:50 +0000	[thread overview]
Message-ID: <CAL3q7H50wBGvT1dVFh0MSZ7V=690Eek86pYq_ct2CN2aViGFHg@mail.gmail.com> (raw)
In-Reply-To: <20191211104029.25541-2-wqu@suse.com>

On Wed, Dec 11, 2019 at 10:40 AM Qu Wenruo <wqu@suse.com> wrote:
>
> Just enabling CONFIG_FAIL_MAKE_REQUEST will not fulfill
> _require_fail_make_request.
>
> It's CONFIG_FAULT_INJECTION_DEBUG_FS.
>
> Signed-off-by: Qu Wenruo <wqu@suse.com>

Reviewed-by: Filipe Manana <fdmanana@suse.com>

Thanks.

> ---
>  common/rc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/rc b/common/rc
> index 5cdd829b..2d72f158 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -2357,7 +2357,7 @@ _require_fail_make_request()
>  {
>      [ -f "$DEBUGFS_MNT/fail_make_request/probability" ] \
>         || _notrun "$DEBUGFS_MNT/fail_make_request \
> - not found. Seems that CONFIG_FAIL_MAKE_REQUEST kernel config option not enabled"
> + not found. Seems that CONFIG_FAULT_INJECTION_DEBUG_FS kernel config option not enabled"
>  }
>
>  # Disable extent zeroing for ext4 on the given device
> --
> 2.23.0
>

-- 
Filipe David Manana,

“Whether you think you can, or you think you can't — you're right.”