From: William Tu <u9012063@gmail.com>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Yi-Hung Wei <yihung.wei@gmail.com>,
David Miller <davem@davemloft.net>, bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH net] selftests/bpf: set gopt opt_class to 0 if get tunnel opt failed
Date: Tue, 9 Mar 2021 10:53:41 -0800 [thread overview]
Message-ID: <CALDO+SZXB8f8zP3sZTHpEgS3xspXbzTVBW18ODSfKsYJna-2Ew@mail.gmail.com> (raw)
In-Reply-To: <20210309032214.2112438-1-liuhangbin@gmail.com>
On Mon, Mar 8, 2021 at 7:22 PM Hangbin Liu <liuhangbin@gmail.com> wrote:
>
> When fixing the bpf test_tunnel.sh genve failure. I only fixed
> the IPv4 part but forgot the IPv6 issue. Similar with the IPv4
> fixes 557c223b643a ("selftests/bpf: No need to drop the packet when
> there is no geneve opt"), when there is no tunnel option and
> bpf_skb_get_tunnel_opt() returns error, there is no need to drop the
> packets and break all geneve rx traffic. Just set opt_class to 0 and
> keep returning TC_ACT_OK at the end.
>
> Fixes: 933a741e3b82 ("selftests/bpf: bpf tunnel test.")
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> ---
LGTM, thanks.
Acked-by: William Tu <u9012063@gmail.com>
next prev parent reply other threads:[~2021-03-09 18:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 3:22 [PATCH net] selftests/bpf: set gopt opt_class to 0 if get tunnel opt failed Hangbin Liu
2021-03-09 18:53 ` William Tu [this message]
2021-03-10 1:37 ` patchwork-bot+netdevbpf
2021-03-10 7:09 ` Hangbin Liu
2021-03-12 1:56 ` Hangbin Liu
2021-03-12 15:15 ` Daniel Borkmann
2021-03-15 6:57 ` Hangbin Liu
2021-03-15 16:32 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALDO+SZXB8f8zP3sZTHpEgS3xspXbzTVBW18ODSfKsYJna-2Ew@mail.gmail.com \
--to=u9012063@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=yihung.wei@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.