All of lore.kernel.org
 help / color / mirror / Atom feed
From: "LI, BO XUAN" <liboxuan@connect.hku.hk>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, sunshine@sunshineco.com
Subject: Re: [PATCH v2] t4253-am-keep-cr-dos: avoid using pipes
Date: Thu, 9 May 2019 00:49:03 +0800	[thread overview]
Message-ID: <CALM0=-mDhCqfL0XpaH27cHxcfRq1Y2xJQ=GQLCVdACsOHj0hiA@mail.gmail.com> (raw)
In-Reply-To: <xmqqv9ylh4wl.fsf@gitster-ct.c.googlers.com>

Hi Junio,

Understood. Thanks for the clarification.

Best regards,
Boxuan Li

On Wed, May 8, 2019 at 1:49 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> "LI, BO XUAN" <liboxuan@connect.hku.hk> writes:
>
> > Thanks for your review! I can understand your point, but I've got a
> > quick question:
> >
> > What if format-patch really breaks and 'am' magically does not break?
>
> Doesn't that indicate that you are not testing the result of "am"
> adequately?
>
> I am not saying it is *wrong* to split the pipe into two.  I am
> merely saying that it is borderline Meh, as the primary point of
> these two tests are to see how the command downstream of the pipe
> behaves and not the upstream one.

      reply	other threads:[~2019-05-08 16:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-05  8:16 [PATCH v2] t4253-am-keep-cr-dos: avoid using pipes Boxuan Li
2019-05-07  9:04 ` Junio C Hamano
2019-05-07 12:42   ` LI, BO XUAN
2019-05-08  5:49     ` Junio C Hamano
2019-05-08 16:49       ` LI, BO XUAN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALM0=-mDhCqfL0XpaH27cHxcfRq1Y2xJQ=GQLCVdACsOHj0hiA@mail.gmail.com' \
    --to=liboxuan@connect.hku.hk \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.