Re: [PATCH] kvm: vmx: Properly handle machine check during VM-entry

From: Jim Mattson <jmattson@google.com>
To: Wanpeng Li <kernellwp@gmail.com>
Cc: Xiao Guangrong <guangrong.xiao@gmail.com>, kvm <kvm@vger.kernel.org>
Subject: Re: [PATCH] kvm: vmx: Properly handle machine check during VM-entry
Date: Mon, 22 May 2017 08:14:22 -0700	[thread overview]
Message-ID: <CALMp9eR2fu9c3FuOFO2GA8_GyZFZDGPotx7B5tS+75-ZaDf=9Q@mail.gmail.com> (raw)
In-Reply-To: <CANRm+Cw=FxEm_g2Fq_Fb_qUY-WxDceQanfKY8_nS09FxmbMfig@mail.gmail.com>

I don't understand the confusion here. Is it because I used Intel's
name for the VMCS field rather than the local variable in this
function? Is it "unmodified" versus "invalid"?

In any case, feel free to use whatever verbiage you are comfortable with.

On Mon, May 22, 2017 at 2:06 AM, Wanpeng Li <kernellwp@gmail.com> wrote:
> 2017-05-22 16:26 GMT+08:00 Xiao Guangrong <guangrong.xiao@gmail.com>:
>>
>>
>> On 05/19/2017 07:02 AM, Jim Mattson wrote:
>>>
>>> When bit 31 of the exit reason is set to indicate a VM-entry failure,
>>> only the exit reason and exit qualification fields are set. All other
>>> VM-exit information fields, including "VM-exit interruption
>>> information," are unmodified.
>>
>>
>> This log does not reflects what it is doing. The case that
>> exit-reason.bit31 = 1 is skipped by the check at the very beginning of
>> vmx_complete_atomic_exit().
>>
>> Maybe what you want to say is just "exit_intr_info is not valid if vmx
>> exit is caused by EXIT_REASON_MCE_DURING_VMENTRY"?
>>
>
> exit_intr_info is not valid for all the vmentry fail. So mce should be
> captured by exit reason instead of interpreting exit_intr_info.
>
> Regards,
> Wanpeng Li