From: Jim Mattson <jmattson@google.com>
To: Nadav Amit <nadav.amit@gmail.com>
Cc: Krish Sadhukhan <krish.sadhukhan@oracle.com>,
kvm list <kvm@vger.kernel.org>, Peter Shier <pshier@google.com>
Subject: Re: [kvm-unit-tests PATCH] kvm-unit-test: x86: Add RDPRU test
Date: Tue, 24 Sep 2019 12:29:29 -0700 [thread overview]
Message-ID: <CALMp9eTiM4+ZnnnXLP-TNrrjfn3DLAurkcY+2Jom5wWqzFe0Jw@mail.gmail.com> (raw)
In-Reply-To: <7ADCB7CB-605D-411A-A082-98B67B7982BE@gmail.com>
On Tue, Sep 24, 2019 at 11:14 AM Nadav Amit <nadav.amit@gmail.com> wrote:
>
> > On Sep 24, 2019, at 11:09 AM, Jim Mattson <jmattson@google.com> wrote:
> >
> > On Tue, Sep 24, 2019 at 10:29 AM Nadav Amit <nadav.amit@gmail.com> wrote:
> >>> On Sep 20, 2019, at 12:44 PM, Jim Mattson <jmattson@google.com> wrote:
> >>>
> >>> On Fri, Sep 20, 2019 at 12:36 PM Krish Sadhukhan
> >>> <krish.sadhukhan@oracle.com> wrote:
> >>>> On 9/19/19 4:02 PM, Jim Mattson wrote:
> >>>>> Ensure that support for RDPRU is not enumerated in the guest's CPUID
> >>>>> and that the RDPRU instruction raises #UD.
> >>>>
> >>>>
> >>>> The AMD spec says,
> >>>>
> >>>> "When the CPL>0 with CR4.TSD=1, the RDPRUinstruction will
> >>>> generate a #UD fault."
> >>>>
> >>>> So we don't need to check the CR4.TSD value here ?
> >>>
> >>> KVM should set CPUID Fn8000_0008_EBX[RDPRU] to 0.
> >>>
> >>> However, I should modify the test so it passes (or skips) on hardware. :-)
> >>
> >> Thanks for making this exception. Just wondering: have you or anyone else
> >> used this functionality - of running tests on bare-metal?
> >
> > I have not. However, if there is a simple way to add this testing to
> > our workflow, I would be happy to ask the team to do so before sending
> > submissions upstream.
>
> I guess I should build some script that uses idrac to automate this process.
I'm not familiar with idrac. What sort of functionality do you need
from the test infrastructure to automate this process?
next prev parent reply other threads:[~2019-09-24 19:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-19 23:02 [kvm-unit-tests PATCH] kvm-unit-test: x86: Add RDPRU test Jim Mattson
2019-09-20 19:36 ` Krish Sadhukhan
2019-09-20 19:44 ` Jim Mattson
2019-09-24 17:29 ` Nadav Amit
2019-09-24 18:09 ` Jim Mattson
2019-09-24 18:14 ` Nadav Amit
2019-09-24 19:29 ` Jim Mattson [this message]
2019-09-24 19:31 ` Nadav Amit
2019-09-25 13:47 ` Paolo Bonzini
2019-09-25 13:43 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALMp9eTiM4+ZnnnXLP-TNrrjfn3DLAurkcY+2Jom5wWqzFe0Jw@mail.gmail.com \
--to=jmattson@google.com \
--cc=krish.sadhukhan@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=nadav.amit@gmail.com \
--cc=pshier@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.