From: Rob Herring <robh@kernel.org>
To: Eric Anholt <eric@anholt.net>
Cc: dri-devel <dri-devel@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
david.emett@broadcom.com, thomas.spurden@broadcom.com
Subject: Re: [PATCH 1/4] drm: Add helpers for locking an array of BO reservations.
Date: Tue, 12 Mar 2019 14:50:20 -0500 [thread overview]
Message-ID: <CAL_Jsq+rV+yR1xUrpXmGsXuPCwZ2w_D69p-u5L9E0e3mJi7zaQ@mail.gmail.com> (raw)
In-Reply-To: <8736nsm1tm.fsf@anholt.net>
On Tue, Mar 12, 2019 at 12:37 PM Eric Anholt <eric@anholt.net> wrote:
>
> Rob Herring <robh@kernel.org> writes:
>
> > On Fri, Mar 8, 2019 at 10:17 AM Eric Anholt <eric@anholt.net> wrote:
> >>
> >> Now that we have the reservation object in the GEM object, it's easy
> >> to provide a helper for this common case. Noticed while reviewing
> >> panfrost and lima drivers. This particular version came out of v3d,
> >> which in turn was a copy from vc4.
> >>
> >> Signed-off-by: Eric Anholt <eric@anholt.net>
> >> ---
> >> drivers/gpu/drm/drm_gem.c | 76 +++++++++++++++++++++++++++++++++++++++
> >> include/drm/drm_gem.h | 4 +++
> >> 2 files changed, 80 insertions(+)
> >
> > Sweet! I was about to go write this same patch. You are changing the
> > license from GPL to MIT copying the v3d version, but I guess you have
> > rights to do that.
> >
> > FWIW,
> >
> > Acked-by: Rob Herring <robh@kernel.org>
>
> Was this just for this one patch, or the series? I don't think I can
> merge without a consumer.
Sure, it can be for patches 1-3. Patch 4 is dependent on me sending
out the shmem helpers again.
Rob
next prev parent reply other threads:[~2019-03-12 19:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-08 16:17 [PATCH 0/4] drm/v3d: Add drm core helper, use shmem helpers Eric Anholt
2019-03-08 16:17 ` [PATCH 1/4] drm: Add helpers for locking an array of BO reservations Eric Anholt
2019-03-08 16:17 ` Eric Anholt
2019-03-08 17:33 ` Rob Herring
2019-03-08 17:46 ` Eric Anholt
2019-03-08 17:46 ` Eric Anholt
2019-03-12 17:37 ` Eric Anholt
2019-03-12 17:37 ` Eric Anholt
2019-03-12 19:50 ` Rob Herring [this message]
2019-03-14 16:28 ` Eric Anholt
2019-03-14 16:28 ` Eric Anholt
2019-03-08 16:17 ` [PATCH 2/4] drm/v3d: Use drm_gem_lock_reservations()/drm_gem_unlock_reservations() Eric Anholt
2019-03-08 16:17 ` [PATCH 3/4] drm/v3d: Remove some dead members of struct v3d_bo Eric Anholt
2019-03-08 16:17 ` Eric Anholt
2019-03-08 16:17 ` [PATCH 4/4] drm/v3d: Use the new shmem helpers to reduce driver boilerplate Eric Anholt
2019-03-08 16:17 ` Eric Anholt
2019-03-08 17:38 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_Jsq+rV+yR1xUrpXmGsXuPCwZ2w_D69p-u5L9E0e3mJi7zaQ@mail.gmail.com \
--to=robh@kernel.org \
--cc=david.emett@broadcom.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas.spurden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.