From: Rob Herring <robh+dt@kernel.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Stephen Boyd <sboyd@kernel.org>, Taniya Das <tdas@codeaurora.org>,
Jeffrey Hugo <jhugo@codeaurora.org>,
Abhishek Sahu <absahu@codeaurora.org>,
sivaprak@codeaurora.org, anusharao@codeaurora.org,
Sricharan <sricharan@codeaurora.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andy Gross <agross@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-clk <linux-clk@vger.kernel.org>
Subject: Re: [PATCH] dt-bindings: clk: qcom: Fix self-validation, split, and clean cruft
Date: Wed, 29 Jan 2020 17:50:12 -0600 [thread overview]
Message-ID: <CAL_JsqLVaJMidm2QcpmxXeT+Q+uU8esm1shdRs3BVoeRYqhJng@mail.gmail.com> (raw)
In-Reply-To: <CAD=FV=XLq4-EdsuKnDjuc3-6P3i6o-tV5MJbdFbvAscF_ouOpg@mail.gmail.com>
On Wed, Jan 29, 2020 at 5:26 PM Doug Anderson <dianders@chromium.org> wrote:
>
> Hi,
>
> On Wed, Jan 29, 2020 at 2:01 PM Rob Herring <robh+dt@kernel.org> wrote:
> >
> > On Wed, Jan 29, 2020 at 3:23 PM Douglas Anderson <dianders@chromium.org> wrote:
> > >
> > > The 'qcom,gcc.yaml' file failed self-validation (dt_binding_check)
> > > because it required a property to be either (3 entries big),
> > > (3 entries big), or (7 entries big), but not more than one of those
> > > things. That didn't make a ton of sense.
> > >
> > > This patch splits all of the exceptional device trees (AKA those that
> > > would have needed if/then/else rules) from qcom,gcc.yaml. It also
> > > cleans up some cruft found while doing that.
> > >
> > > After this lands, this worked for me atop clk-next:
> > > for f in \
> > > Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml \
> > > Documentation/devicetree/bindings/clock/qcom,gcc-ipq8074.yaml \
> > > Documentation/devicetree/bindings/clock/qcom,gcc-msm8996.yaml \
> > > Documentation/devicetree/bindings/clock/qcom,gcc-msm8998.yaml \
> > > Documentation/devicetree/bindings/clock/qcom,gcc-qcs404.yaml \
> > > Documentation/devicetree/bindings/clock/qcom,gcc-sc7180.yaml \
> > > Documentation/devicetree/bindings/clock/qcom,gcc-sm8150.yaml \
> > > Documentation/devicetree/bindings/clock/qcom,gcc.yaml; do \
> > > ARCH=arm64 make dt_binding_check DT_SCHEMA_FILES=$f; \
> > > ARCH=arm64 make dtbs_check DT_SCHEMA_FILES=$f; \
> > > done
> >
> > Note that using DT_SCHEMA_FILES may hide some errors in examples as
> > all other schemas (including the core ones) are not used for
> > validation. So just 'make dt_binding_check' needs to pass (ignoring
> > any other unrelated errors as it breaks frequently). Supposedly a
> > patch is coming explaining this in the documentation.
>
> That seems like it's going to be a huge pain going forward, but OK.
Use of DT_SCHEMA_FILES hiding problems or having to run 'make
dt_binding_check' on everything?
I could probably rework things such that you can check a single
binding example against all schema, but dtbs still get validated by
just a single schema.
The other option is proper makefiles in every directory so you can do
'make Documentation/devicetree/bindings/clk/'. But like compiling a
directory, that doesn't catch all issues (linking).
> I
> kept running "dtbs_check" with the DT_SCHEMA_FILES since I guess this
> was OK? Then I ran this atop next-20200129:
Yes, that's really where DT_SCHEMA_FILES is most useful IMO.
> # Delete broken yaml:
> rm Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml
Been waiting on the fix to be applied since Dec...
> ARCH=arm64 make dt_binding_check | grep 'clock/qcom'
>
> ...and that seemed OK to me. I've updated the commit message to
> include what I did. Hopefully it's right.
Probably is. There are cases where a new schema breaks another file's
example. If someone has a gcc node in another example for example.
Rob
next prev parent reply other threads:[~2020-01-29 23:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 21:23 [PATCH] dt-bindings: clk: qcom: Fix self-validation, split, and clean cruft Douglas Anderson
2020-01-29 21:47 ` Jeffrey Hugo
2020-01-29 22:00 ` Rob Herring
2020-01-29 23:26 ` Doug Anderson
2020-01-29 23:50 ` Rob Herring [this message]
2020-01-30 0:24 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqLVaJMidm2QcpmxXeT+Q+uU8esm1shdRs3BVoeRYqhJng@mail.gmail.com \
--to=robh+dt@kernel.org \
--cc=absahu@codeaurora.org \
--cc=agross@kernel.org \
--cc=anusharao@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=jhugo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=sivaprak@codeaurora.org \
--cc=sricharan@codeaurora.org \
--cc=tdas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.