Re: [PATCH net-next 10/12] bnxt_en: Support RSS contexts in ethtool .{get|set}_rxfh()

From: Pavan Chebbi <pavan.chebbi@broadcom.com>
To: Edward Cree <ecree.xilinx@gmail.com>
Cc: Michael Chan <michael.chan@broadcom.com>,
	davem@davemloft.net, netdev@vger.kernel.org,
	 edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	 andrew.gospodarek@broadcom.com,
	 Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Subject: Re: [PATCH net-next 10/12] bnxt_en: Support RSS contexts in ethtool .{get|set}_rxfh()
Date: Tue, 26 Mar 2024 17:13:31 +0530	[thread overview]
Message-ID: <CALs4sv2dyy3uy+Xznm41M3uOkv1TSoGMwVBL5Cwzv=_E=+L_4A@mail.gmail.com> (raw)
In-Reply-To: <6f302b24-6ca4-4c16-9808-9cf89cda0ffe@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 916 bytes --]

On Tue, Mar 26, 2024 at 4:20 PM Edward Cree <ecree.xilinx@gmail.com> wrote:
>
> On 25/03/2024 22:29, Michael Chan wrote:
> > From: Pavan Chebbi <pavan.chebbi@broadcom.com>
> >
> > Support up to 32 RSS contexts per device if supported by the device.
>
> Is this maximum of 32 driven by hardware limitations, or was a fixed
>  limit chosen to simplify state management on the driver side?

It's the latter for now. However, though much higher, the hardware
does have a limit. (different on every generation of the chip)
So I guess we need the limit identifier in your work. Thanks for reviewing.

> I ask because at some point in the future I hope to get back to my
>  rewrite of the kernel API (see [1]) and this info may help me to
>  port your driver correctly.
>
> -ed
>
> [1]: https://lore.kernel.org/netdev/4a41069859105d8c669fe26171248aad7f88d1e9.1695838185.git.ecree.xilinx@gmail.com/T/

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]