Re: [PATCH v2 08/10] KVM: selftests: Drop unnecessary rule for $(LIBKVM_OBJS)

From: David Matlack <dmatlack@google.com>
To: Peter Xu <peterx@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Ben Gardon <bgardon@google.com>,
	Sean Christopherson <seanjc@google.com>,
	Oliver Upton <oupton@google.com>,
	Vitaly Kuznetsov <vkuznets@redhat.com>,
	Andrew Jones <drjones@redhat.com>,
	"open list:KERNEL VIRTUAL MACHINE (KVM)" <kvm@vger.kernel.org>
Subject: Re: [PATCH v2 08/10] KVM: selftests: Drop unnecessary rule for $(LIBKVM_OBJS)
Date: Wed, 18 May 2022 10:18:27 -0700	[thread overview]
Message-ID: <CALzav=eET=9bS5O5bSs3YYc+1BuJBw6NDmPO6YLWL1V_MhBJag@mail.gmail.com> (raw)
In-Reply-To: <YoQD0EDDeW+P3rSh@xz-m1.local>

On Tue, May 17, 2022 at 1:21 PM Peter Xu <peterx@redhat.com> wrote:
>
> On Tue, May 17, 2022 at 07:05:22PM +0000, David Matlack wrote:
> > Drop the "all: $(LIBKVM_OBJS)" rule. The KVM selftests already depend
> > on $(LIBKVM_OBJS), so there is no reason to have this rule.
> >
> > Suggested-by: Peter Xu <peterx@redhat.com>
> > Signed-off-by: David Matlack <dmatlack@google.com>
>
> Since previous patch touched the same line, normally for such a trivial
> change I'll just squash into it.  Or at least it should be before the
> previous patch then that one contains one less LOC change.  Anyway:

The previous patch does touch this line but this is a logically
distinct change so I think it makes sense to split out.

You're right though that it'd probably make sense to re-order this
before the previous patch. i.e. Drop the line "all: $(STATIC_LIBS)".

>
> Reviewed-by: Peter Xu <peterx@redhat.com>
>
> Thanks,
>
> > ---
> >  tools/testing/selftests/kvm/Makefile | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/tools/testing/selftests/kvm/Makefile b/tools/testing/selftests/kvm/Makefile
> > index cd7a9df4ad6d..0889fc17baa5 100644
> > --- a/tools/testing/selftests/kvm/Makefile
> > +++ b/tools/testing/selftests/kvm/Makefile
> > @@ -189,7 +189,6 @@ $(LIBKVM_S_OBJ): $(OUTPUT)/%.o: %.S
> >       $(CC) $(CFLAGS) $(CPPFLAGS) $(TARGET_ARCH) -c $< -o $@
> >
> >  x := $(shell mkdir -p $(sort $(dir $(TEST_GEN_PROGS))))
> > -all: $(LIBKVM_OBJS)
> >  $(TEST_GEN_PROGS): $(LIBKVM_OBJS)
> >
> >  cscope: include_paths = $(LINUX_TOOL_INCLUDE) $(LINUX_HDR_PATH) include lib ..
> > --
> > 2.36.0.550.gb090851708-goog
> >
>
> --
> Peter Xu
>