From: Namhyung Kim <namhyung@kernel.org>
To: Kan Liang <kan.liang@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Stephane Eranian <eranian@google.com>,
Michael Ellerman <mpe@ellerman.id.au>,
linux-kernel <linux-kernel@vger.kernel.org>,
Andi Kleen <ak@linux.intel.com>,
andreas.kogler.0x@gmail.com,
Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
Ravi Bangoria <ravi.bangoria@amd.com>
Subject: Re: [PATCH V2 0/6] Add sample_flags to improve the perf_sample_data struct
Date: Thu, 1 Sep 2022 22:32:55 -0700 [thread overview]
Message-ID: <CAM9d7cgGPE7q9xhdxQtgv94i+SF-3+T2txdnY8m2P0qsSVWnkQ@mail.gmail.com> (raw)
In-Reply-To: <20220901130959.1285717-1-kan.liang@linux.intel.com>
On Thu, Sep 1, 2022 at 6:10 AM <kan.liang@linux.intel.com> wrote:
>
> From: Kan Liang <kan.liang@linux.intel.com>
>
> Changes since V1:
> - Update the AMD LBR code in patch 3
>
> The patch series is to fix PEBS timestamps overwritten and improve the
> perf_sample_data struct. The detailed discussion can be found at
> https://lore.kernel.org/lkml/YwXvGe4%2FQdgGYOKJ@worktop.programming.kicks-ass.net/
>
> The patch series has two changes compared with the suggestions in the
> above discussion.
> - Only clear the sample flags for the perf_prepare_sample().
> The __perf_event_header__init_id is shared between perf_prepare_sample()
> (used by PERF_RECORD_SAMPLE) and perf_event_header__init_id() (used by
> other PERF_RECORD_* event type). The sample data is only available
> for the PERF_RECORD_SAMPLE.
> - The CALLCHAIN_EARLY hack is still required for the BPF, especially
> perf_event_set_bpf_handler(). The sample data is not available when
> the function is invoked.
>
> Kan Liang (6):
> perf: Add sample_flags to indicate the PMU-filled sample data
> perf/x86/intel/pebs: Fix PEBS timestamps overwritten
> perf: Use sample_flags for branch stack
> perf: Use sample_flags for weight
> perf: Use sample_flags for data_src
> perf: Use sample_flags for txn
Maybe we can get rid of perf_sample_data_init() completely.
But it could be done later, so
Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks,
Namhyung
>
> arch/powerpc/perf/core-book3s.c | 10 ++++++---
> arch/x86/events/amd/core.c | 4 +++-
> arch/x86/events/core.c | 4 +++-
> arch/x86/events/intel/core.c | 4 +++-
> arch/x86/events/intel/ds.c | 39 ++++++++++++++++++++++++---------
> include/linux/perf_event.h | 15 ++++++-------
> kernel/events/core.c | 30 ++++++++++++++++++-------
> 7 files changed, 74 insertions(+), 32 deletions(-)
>
> --
> 2.35.1
>
next prev parent reply other threads:[~2022-09-02 5:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 13:09 [PATCH V2 0/6] Add sample_flags to improve the perf_sample_data struct kan.liang
2022-09-01 13:09 ` [PATCH V2 1/6] perf: Add sample_flags to indicate the PMU-filled sample data kan.liang
2022-09-06 9:41 ` [tip: perf/core] " tip-bot2 for Kan Liang
2022-09-01 13:09 ` [PATCH V2 2/6] perf/x86/intel/pebs: Fix PEBS timestamps overwritten kan.liang
2022-09-06 9:41 ` [tip: perf/core] " tip-bot2 for Kan Liang
2022-10-11 18:20 ` [PATCH V2 2/6] " Namhyung Kim
2022-10-12 8:04 ` Peter Zijlstra
2022-10-12 16:12 ` Namhyung Kim
2022-09-01 13:09 ` [PATCH V2 3/6] perf: Use sample_flags for branch stack kan.liang
2022-09-06 9:41 ` [tip: perf/core] " tip-bot2 for Kan Liang
2022-09-27 11:04 ` [PATCH V2 3/6] " Jiri Olsa
2022-09-01 13:09 ` [PATCH V2 4/6] perf: Use sample_flags for weight kan.liang
2022-09-02 5:29 ` Namhyung Kim
2022-09-06 13:56 ` Liang, Kan
2022-09-06 9:41 ` [tip: perf/core] " tip-bot2 for Kan Liang
2022-09-01 13:09 ` [PATCH V2 5/6] perf: Use sample_flags for data_src kan.liang
2022-09-06 9:41 ` [tip: perf/core] " tip-bot2 for Kan Liang
2022-09-01 13:09 ` [PATCH V2 6/6] perf: Use sample_flags for txn kan.liang
2022-09-06 9:41 ` [tip: perf/core] " tip-bot2 for Kan Liang
2022-09-02 5:32 ` Namhyung Kim [this message]
2022-09-05 3:33 ` [PATCH V2 0/6] Add sample_flags to improve the perf_sample_data struct Ravi Bangoria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM9d7cgGPE7q9xhdxQtgv94i+SF-3+T2txdnY8m2P0qsSVWnkQ@mail.gmail.com \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andreas.kogler.0x@gmail.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=eranian@google.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.