Re: [PATCH] scsi: pm80xx: Set stopped phy's linkrate to Disabled

From: Jinpu Wang <jinpu.wang@ionos.com>
To: Changyuan Lyu <changyuanl@google.com>
Cc: Jack Wang <jinpu.wang@ionos.com>,
	"James E . J . Bottomley" <jejb@linux.ibm.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	linux-scsi@vger.kernel.org, Igor Pylypiv <ipylypiv@google.com>
Subject: Re: [PATCH] scsi: pm80xx: Set stopped phy's linkrate to Disabled
Date: Sat, 9 Jul 2022 08:20:50 +0200	[thread overview]
Message-ID: <CAMGffEkqXWTrJN-hHj4UE+Fcdm-hDBO2Q++bPcd2wQhJjNiQiQ@mail.gmail.com> (raw)
In-Reply-To: <20220708205026.969161-1-changyuanl@google.com>

On Fri, Jul 8, 2022 at 10:50 PM Changyuan Lyu <changyuanl@google.com> wrote:
>
> Negotiated link rate needs to be updated to Disabled when phy is
> stopped.
>
> Reviewed-by: Igor Pylypiv <ipylypiv@google.com>
> Signed-off-by: Changyuan Lyu <changyuanl@google.com>
Acked-by: Jack Wang <jinpu.wang@ionso.com>
> ---
>  drivers/scsi/pm8001/pm80xx_hwi.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/pm8001/pm80xx_hwi.c b/drivers/scsi/pm8001/pm80xx_hwi.c
> index 01c5e8ff4cc5..303cd05fec50 100644
> --- a/drivers/scsi/pm8001/pm80xx_hwi.c
> +++ b/drivers/scsi/pm8001/pm80xx_hwi.c
> @@ -3723,8 +3723,12 @@ static int mpi_phy_stop_resp(struct pm8001_hba_info *pm8001_ha, void *piomb)
>         pm8001_dbg(pm8001_ha, MSG, "phy:0x%x status:0x%x\n",
>                    phyid, status);
>         if (status == PHY_STOP_SUCCESS ||
> -               status == PHY_STOP_ERR_DEVICE_ATTACHED)
> +               status == PHY_STOP_ERR_DEVICE_ATTACHED) {
>                 phy->phy_state = PHY_LINK_DISABLE;
> +               phy->sas_phy.phy->negotiated_linkrate = SAS_PHY_DISABLED;
> +               phy->sas_phy.linkrate = SAS_PHY_DISABLED;
> +       }
> +
>         return 0;
>  }
>
> --
> 2.37.0.rc0.161.g10f37bed90-goog
>