From: Eric Miao <eric.miao@linaro.org>
To: Shawn Guo <shawn.guo@freescale.com>
Cc: Shawn Guo <shawn.guo@linaro.org>,
linux-input@vger.kernel.org, patches@linaro.org,
Dmitry Torokhov <dtor@mail.ru>,
devicetree-discuss@lists.ozlabs.org,
Sammy He <r62914@freescale.com>
Subject: Re: [PATCH] Input: mma8450: add device tree probe support
Date: Fri, 29 Jul 2011 11:00:15 +0800 [thread overview]
Message-ID: <CAMPhdO-VbfQoLXpNLDBTW=rKkvPmUF6YRA6HVeNjsmSE5ob1Gg@mail.gmail.com> (raw)
In-Reply-To: <20110729023855.GC1946@S2100-06.ap.freescale.net>
On Fri, Jul 29, 2011 at 10:38 AM, Shawn Guo <shawn.guo@freescale.com> wrote:
> Any comments?
>
Shawn,
Patch looks OK to me.
> Regards,
> Shawn
>
> On Fri, Jul 22, 2011 at 12:25:51AM +0800, Shawn Guo wrote:
>> It adds device tree probe support for mma8450 driver.
>>
>> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
>> Cc: Grant Likely <grant.likely@secretlab.ca>
>> Cc: Sammy He <r62914@freescale.com>
>> Cc: Eric Miao <eric.miao@linaro.org>
>> Cc: Dmitry Torokhov <dtor@mail.ru>
>> ---
>> .../devicetree/bindings/input/fsl-mma8450.txt | 11 +++++++++++
>> drivers/input/misc/mma8450.c | 8 ++++++++
>> 2 files changed, 19 insertions(+), 0 deletions(-)
>> create mode 100644 Documentation/devicetree/bindings/input/fsl-mma8450.txt
>>
>> diff --git a/Documentation/devicetree/bindings/input/fsl-mma8450.txt b/Documentation/devicetree/bindings/input/fsl-mma8450.txt
>> new file mode 100644
>> index 0000000..a00c94c
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/input/fsl-mma8450.txt
>> @@ -0,0 +1,11 @@
>> +* Freescale MMA8450 3-Axis Accelerometer
>> +
>> +Required properties:
>> +- compatible : "fsl,mma8450".
>> +
>> +Example:
>> +
>> +accelerometer: mma8450@1c {
>> + compatible = "fsl,mma8450";
>> + reg = <0x1c>;
>> +};
>> diff --git a/drivers/input/misc/mma8450.c b/drivers/input/misc/mma8450.c
>> index 20f8f92..6c76cf7 100644
>> --- a/drivers/input/misc/mma8450.c
>> +++ b/drivers/input/misc/mma8450.c
>> @@ -24,6 +24,7 @@
>> #include <linux/delay.h>
>> #include <linux/i2c.h>
>> #include <linux/input-polldev.h>
>> +#include <linux/of_device.h>
>>
>> #define MMA8450_DRV_NAME "mma8450"
>>
>> @@ -229,10 +230,17 @@ static const struct i2c_device_id mma8450_id[] = {
>> };
>> MODULE_DEVICE_TABLE(i2c, mma8450_id);
>>
>> +static const struct of_device_id mma8450_dt_ids[] = {
>> + { .compatible = "fsl,mma8450", },
>> + { /* sentinel */ }
>> +};
>> +MODULE_DEVICE_TABLE(i2c, mma8450_dt_ids);
>> +
>> static struct i2c_driver mma8450_driver = {
>> .driver = {
>> .name = MMA8450_DRV_NAME,
>> .owner = THIS_MODULE,
>> + .of_match_table = mma8450_dt_ids,
>> },
>> .probe = mma8450_probe,
>> .remove = __devexit_p(mma8450_remove),
>> --
>> 1.7.4.1
>>
>> _______________________________________________
>> devicetree-discuss mailing list
>> devicetree-discuss@lists.ozlabs.org
>> https://lists.ozlabs.org/listinfo/devicetree-discuss
>>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-07-29 3:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-21 16:25 [PATCH] Input: mma8450: add device tree probe support Shawn Guo
2011-07-29 2:38 ` Shawn Guo
2011-07-29 3:00 ` Eric Miao [this message]
2011-07-31 3:07 ` Grant Likely
2011-08-01 2:56 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMPhdO-VbfQoLXpNLDBTW=rKkvPmUF6YRA6HVeNjsmSE5ob1Gg@mail.gmail.com' \
--to=eric.miao@linaro.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dtor@mail.ru \
--cc=linux-input@vger.kernel.org \
--cc=patches@linaro.org \
--cc=r62914@freescale.com \
--cc=shawn.guo@freescale.com \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.