From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Kent Gibson <warthog618@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Shuah Khan <shuah@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v11 2/6] gpiolib: allow to specify the firmware node in struct gpio_chip
Date: Tue, 30 Nov 2021 19:32:28 +0100 [thread overview]
Message-ID: <CAMRc=MdRMeyzonY+AZa8CWfh6Bk64e3OXAmGk3X=rx=DrM4-mw@mail.gmail.com> (raw)
In-Reply-To: <YaZPACT53i4LovrM@smile.fi.intel.com>
On Tue, Nov 30, 2021 at 5:20 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Tue, Nov 30, 2021 at 06:14:01PM +0200, Andy Shevchenko wrote:
> > On Tue, Nov 30, 2021 at 04:41:23PM +0100, Bartosz Golaszewski wrote:
>
> ...
>
> > Not sure I understand the proposal. Can you provide couple of (simplest)
> > examples?
> >
> > And also it sounds like reinventing a wheel. What problem do you have that you
> > need to solve this way?
>
> Have you seen these:
> drivers/gpio/gpio-dwapb.c
> drivers/mfd/intel_quark_i2c_gpio.c
> ?
>
> GPIO driver has a main (controller level) node along with children on per bank
> basis. Currently it works with the provided approach (see second driver).
>
> --
> With Best Regards,
> Andy Shevchenko
>
>
Yep, I know dwapd. What happens in probe is that each bank device is
created using the properties from the associated child fwnode but the
parent device's fwnode is actually assigned as the gpiochip's fwnode.
This is logically wrong and OF doesn't do it - it assigns the child
of_node to the child device if gpio_chip->of_node is assigned in the
driver. I'm not sure if ACPI does this.
Non-OF drivers don't have a way to do this and this patch enables it.
I want to add it mostly because gpio-sim can then use the software
node to identify the device in the configfs by that software node but
IMO this is logically correct too.
Bart
next prev parent reply other threads:[~2021-11-30 18:32 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 15:41 [PATCH v11 0/6] gpio-sim: configfs-based GPIO simulator Bartosz Golaszewski
2021-11-30 15:41 ` [PATCH v11 1/6] gpiolib: provide gpiod_remove_hogs() Bartosz Golaszewski
2021-11-30 15:41 ` [PATCH v11 2/6] gpiolib: allow to specify the firmware node in struct gpio_chip Bartosz Golaszewski
2021-11-30 16:14 ` Andy Shevchenko
2021-11-30 16:19 ` Andy Shevchenko
2021-11-30 16:55 ` Andy Shevchenko
2021-11-30 18:32 ` Bartosz Golaszewski [this message]
2021-11-30 20:31 ` Andy Shevchenko
2021-11-30 20:25 ` Bartosz Golaszewski
2021-11-30 20:59 ` Andy Shevchenko
2021-11-30 21:04 ` Bartosz Golaszewski
2021-12-01 13:11 ` Bartosz Golaszewski
2021-12-01 13:39 ` Andy Shevchenko
2021-12-01 13:53 ` Bartosz Golaszewski
2021-12-01 14:28 ` Andy Shevchenko
2021-12-01 14:33 ` Andy Shevchenko
2021-12-01 14:36 ` Bartosz Golaszewski
2021-12-01 14:54 ` Andy Shevchenko
2021-12-02 10:57 ` Andy Shevchenko
2021-12-02 11:24 ` Bartosz Golaszewski
2021-12-02 11:35 ` Andy Shevchenko
2021-12-02 11:37 ` Andy Shevchenko
2021-12-02 13:06 ` Bartosz Golaszewski
2021-12-02 13:44 ` Andy Shevchenko
2021-12-02 13:52 ` Bartosz Golaszewski
2021-12-02 15:40 ` Andy Shevchenko
2021-12-02 17:00 ` Bartosz Golaszewski
2021-12-02 17:29 ` Andy Shevchenko
2021-11-30 15:41 ` [PATCH v11 3/6] gpio: sim: new testing module Bartosz Golaszewski
2021-12-01 2:55 ` kernel test robot
2021-12-01 8:59 ` Bartosz Golaszewski
2021-11-30 15:41 ` [PATCH v11 4/6] selftests: gpio: provide a helper for reading chip info Bartosz Golaszewski
2021-11-30 15:41 ` [PATCH v11 5/6] selftests: gpio: add a helper for reading GPIO line names Bartosz Golaszewski
2021-11-30 15:41 ` [PATCH v11 6/6] selftests: gpio: add test cases for gpio-sim Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMRc=MdRMeyzonY+AZa8CWfh6Bk64e3OXAmGk3X=rx=DrM4-mw@mail.gmail.com' \
--to=brgl@bgdev.pl \
--cc=andriy.shevchenko@linux.intel.com \
--cc=geert@linux-m68k.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.