From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
Jassi Brar <jaswinder.singh@linaro.org>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Iyappan Subramanian <iyappan@os.amperecomputing.com>,
Keyur Chudgar <keyur@os.amperecomputing.com>,
Quan Nguyen <quan@os.amperecomputing.com>,
Frank Rowand <frowand.list@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, netdev <netdev@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC..."
<linux-mediatek@lists.infradead.org>,
Fabien Parent <fparent@baylibre.com>,
Stephane Le Provost <stephane.leprovost@mediatek.com>,
Pedro Tsai <pedro.tsai@mediatek.com>,
Andrew Perepech <andrew.perepech@mediatek.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH 14/15] net: phy: add PHY regulator support
Date: Tue, 23 Jun 2020 11:41:11 +0200 [thread overview]
Message-ID: <CAMRc=Me1r3Mzfg3-gTsGk4rEtvB=P9ESkn9q=c7z0Q=YQDsw2A@mail.gmail.com> (raw)
In-Reply-To: <20200622132921.GI1551@shell.armlinux.org.uk>
pon., 22 cze 2020 o 15:29 Russell King - ARM Linux admin
<linux@armlinux.org.uk> napisał(a):
>
[snip!]
>
> This is likely to cause issues for some PHY drivers. Note that we have
> some PHY drivers which register a temperature sensor in the probe
> function, which means they can be accessed independently of the lifetime
> of the PHY bound to the network driver (which may only be while the
> network device is "up".) We certainly do not want hwmon failing just
> because the network device is down.
>
> That's kind of worked around for the reset stuff, because there are two
> layers to that: the mdio device layer reset support which knows nothing
> of the PHY binding state to the network driver, and the phylib reset
> support, but it is not nice.
>
Regulators are reference counted so if the hwmon driver enables it
using mdio_device_power_on() it will stay on even after the PHY driver
calls phy_device_power_off(), right? Am I missing something?
Bart
next prev parent reply other threads:[~2020-06-23 9:41 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-22 9:37 [PATCH 00/15] net: phy: correctly model the PHY voltage supply in DT Bartosz Golaszewski
2020-06-22 9:37 ` [PATCH 01/15] net: phy: arrange headers in mdio_bus.c alphabetically Bartosz Golaszewski
2020-06-22 13:12 ` Andrew Lunn
2020-06-23 18:54 ` Florian Fainelli
2020-06-23 18:54 ` Florian Fainelli
2020-06-23 18:54 ` Florian Fainelli
2020-06-22 9:37 ` [PATCH 02/15] net: phy: arrange headers in mdio_device.c alphabetically Bartosz Golaszewski
2020-06-22 13:12 ` Andrew Lunn
2020-06-23 18:56 ` Florian Fainelli
2020-06-23 18:56 ` Florian Fainelli
2020-06-23 18:56 ` Florian Fainelli
2020-06-22 9:37 ` [PATCH 03/15] net: phy: arrange headers in phy_device.c alphabetically Bartosz Golaszewski
2020-06-22 13:12 ` Andrew Lunn
2020-06-23 18:57 ` Florian Fainelli
2020-06-23 18:57 ` Florian Fainelli
2020-06-23 18:57 ` Florian Fainelli
2020-06-22 9:37 ` [PATCH 04/15] net: mdio: add a forward declaration for reset_control to mdio.h Bartosz Golaszewski
2020-06-22 13:13 ` Andrew Lunn
2020-06-23 18:59 ` Florian Fainelli
2020-06-23 18:59 ` Florian Fainelli
2020-06-23 18:59 ` Florian Fainelli
2020-06-22 9:37 ` [PATCH 05/15] net: phy: reset the PHY even if probe() is not implemented Bartosz Golaszewski
2020-06-22 13:16 ` Andrew Lunn
2020-06-23 19:14 ` Florian Fainelli
2020-06-23 19:14 ` Florian Fainelli
2020-06-23 19:14 ` Florian Fainelli
2020-06-24 16:22 ` Bartosz Golaszewski
2020-06-24 16:22 ` Bartosz Golaszewski
2020-06-24 16:22 ` Bartosz Golaszewski
2020-06-22 9:37 ` [PATCH 06/15] net: phy: mdio: reset MDIO devices " Bartosz Golaszewski
2020-06-22 13:18 ` Andrew Lunn
2020-06-23 19:16 ` Florian Fainelli
2020-06-23 19:16 ` Florian Fainelli
2020-06-23 19:16 ` Florian Fainelli
2020-06-22 9:37 ` [PATCH 07/15] net: phy: split out the PHY driver request out of phy_device_create() Bartosz Golaszewski
2020-06-22 9:37 ` [PATCH 08/15] net: phy: check the PHY presence in get_phy_id() Bartosz Golaszewski
2020-06-22 9:37 ` [PATCH 09/15] net: phy: delay PHY driver probe until PHY registration Bartosz Golaszewski
2020-06-22 13:39 ` Andrew Lunn
2020-06-22 13:51 ` Mark Brown
2020-06-23 19:49 ` Florian Fainelli
2020-06-23 19:49 ` Florian Fainelli
2020-06-23 19:49 ` Florian Fainelli
2020-06-24 9:43 ` Mark Brown
2020-06-24 9:43 ` Mark Brown
2020-06-24 9:43 ` Mark Brown
2020-06-24 13:48 ` Bartosz Golaszewski
2020-06-24 13:48 ` Bartosz Golaszewski
2020-06-24 13:48 ` Bartosz Golaszewski
2020-06-24 16:06 ` Florian Fainelli
2020-06-24 16:06 ` Florian Fainelli
2020-06-24 16:06 ` Florian Fainelli
2020-06-24 16:35 ` Bartosz Golaszewski
2020-06-24 16:35 ` Bartosz Golaszewski
2020-06-24 16:35 ` Bartosz Golaszewski
2020-06-24 16:50 ` Russell King - ARM Linux admin
2020-06-24 16:50 ` Russell King - ARM Linux admin
2020-06-24 16:50 ` Russell King - ARM Linux admin
2020-06-24 18:59 ` Robin Murphy
2020-06-24 18:59 ` Robin Murphy
2020-06-24 18:59 ` Robin Murphy
2020-06-22 9:37 ` [PATCH 10/15] net: phy: simplify phy_device_create() Bartosz Golaszewski
2020-06-22 9:37 ` [PATCH 11/15] net: phy: drop get_phy_device() Bartosz Golaszewski
2020-06-22 19:29 ` kernel test robot
2020-06-22 9:37 ` [PATCH 12/15] dt-bindings: mdio: add phy-supply property to ethernet phy node Bartosz Golaszewski
2020-06-23 19:39 ` Florian Fainelli
2020-06-23 19:39 ` Florian Fainelli
2020-06-23 19:39 ` Florian Fainelli
2020-06-22 9:37 ` [PATCH 13/15] net: phy: mdio: add support for PHY supply regulator Bartosz Golaszewski
2020-06-22 13:25 ` Russell King - ARM Linux admin
2020-06-23 9:30 ` Bartosz Golaszewski
2020-06-22 9:37 ` [PATCH 14/15] net: phy: add PHY regulator support Bartosz Golaszewski
2020-06-22 13:29 ` Russell King - ARM Linux admin
2020-06-23 9:41 ` Bartosz Golaszewski [this message]
2020-06-23 9:42 ` Russell King - ARM Linux admin
2020-06-23 9:46 ` Bartosz Golaszewski
2020-06-23 9:56 ` Russell King - ARM Linux admin
2020-06-23 16:27 ` Bartosz Golaszewski
2020-06-23 16:27 ` Bartosz Golaszewski
2020-06-23 16:27 ` Bartosz Golaszewski
2020-06-24 16:57 ` Russell King - ARM Linux admin
2020-06-24 16:57 ` Russell King - ARM Linux admin
2020-06-24 16:57 ` Russell King - ARM Linux admin
2020-06-24 18:12 ` Russell King - ARM Linux admin
2020-06-24 18:12 ` Russell King - ARM Linux admin
2020-06-24 18:12 ` Russell King - ARM Linux admin
2020-06-22 9:37 ` [PATCH 15/15] ARM64: dts: mediatek: add a phy regulator to pumpkin-common.dtsi Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMRc=Me1r3Mzfg3-gTsGk4rEtvB=P9ESkn9q=c7z0Q=YQDsw2A@mail.gmail.com' \
--to=brgl@bgdev.pl \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew.perepech@mediatek.com \
--cc=andrew@lunn.ch \
--cc=bgolaszewski@baylibre.com \
--cc=broonie@kernel.org \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=fparent@baylibre.com \
--cc=frowand.list@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=ilias.apalodimas@linaro.org \
--cc=iyappan@os.amperecomputing.com \
--cc=jaswinder.singh@linaro.org \
--cc=keyur@os.amperecomputing.com \
--cc=kuba@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pedro.tsai@mediatek.com \
--cc=quan@os.amperecomputing.com \
--cc=robh+dt@kernel.org \
--cc=stephane.leprovost@mediatek.com \
--cc=thomas.lendacky@amd.com \
--cc=vivien.didelot@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.