From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: dummy_evgen: modify the return value check for irq_sim_init()
Date: Sat, 2 Dec 2017 16:33:59 +0100 [thread overview]
Message-ID: <CAMRc=MehxFFxGU6vWyBaLWn7S_zR1+6B17mogFw4V1OS-Tq-cQ@mail.gmail.com> (raw)
In-Reply-To: <20171202114338.58c077dc@archlinux>
2017-12-02 12:43 GMT+01:00 Jonathan Cameron <jic23@kernel.org>:
> On Mon, 27 Nov 2017 11:54:49 +0100
> Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
>> As discussed with Marc Zyngier: irq_sim_init() and its devres variant
>> should return the base of the allocated interrupt range on success
>> rather than 0. This will be modified later - first, change the way
>> users handle the return value of these routines.
>>
>> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
> I'm happy to take this but if it goes via my tree whilst the
> other changes take a different path you are going to slow things
> down considerably (a kernel cycle for this change to be in the
> upstream of where the fix gets applied). So I would bundle
> it up in a single patch set with the more major changes.
>
> If you still want me to take it let me know, but if it
> might go via another route then
>
> Acked-by: Jonathan Cameron <jonathan.cameron@huawei.com>
>
> Thanks,
>
> Jonathan
>> ---
>> drivers/iio/dummy/iio_dummy_evgen.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/iio/dummy/iio_dummy_evgen.c b/drivers/iio/dummy/iio_dummy_evgen.c
>> index fe8884543da0..efd0005f59b4 100644
>> --- a/drivers/iio/dummy/iio_dummy_evgen.c
>> +++ b/drivers/iio/dummy/iio_dummy_evgen.c
>> @@ -56,7 +56,7 @@ static int iio_dummy_evgen_create(void)
>> return -ENOMEM;
>>
>> ret = irq_sim_init(&iio_evgen->irq_sim, IIO_EVENTGEN_NO);
>> - if (ret) {
>> + if (ret < 0) {
>> kfree(iio_evgen);
>> return ret;
>> }
>
There's no hurry with that, it doesn't cause any problems really and
the same change must be applied to gpio-mockup. I planned to actually
change the return value for 4.17 after all users are modified for
4.16.
How does it sound?
Thanks,
Bartosz
next prev parent reply other threads:[~2017-12-02 15:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 10:54 [PATCH] iio: dummy_evgen: modify the return value check for irq_sim_init() Bartosz Golaszewski
2017-12-02 11:43 ` Jonathan Cameron
2017-12-02 15:33 ` Bartosz Golaszewski [this message]
2017-12-10 15:02 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMRc=MehxFFxGU6vWyBaLWn7S_zR1+6B17mogFw4V1OS-Tq-cQ@mail.gmail.com' \
--to=brgl@bgdev.pl \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.