From: Vincent MAILHOL <mailhol.vincent@wanadoo.fr>
To: linux-can@vger.kernel.org
Cc: Marc Kleine-Budde <mkl@pengutronix.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] can: etas_es58x: sort the includes by alphabetic order
Date: Tue, 8 Nov 2022 15:15:41 +0900 [thread overview]
Message-ID: <CAMZ6RqKZJcSq=dMh84gacY3yh_4=XnW=Hupq4dZztE681ZACHg@mail.gmail.com> (raw)
In-Reply-To: <20221106125546.855266-1-mailhol.vincent@wanadoo.fr>
On Sun. 6 Nov. 2022 at 21:56, Vincent Mailhol
<mailhol.vincent@wanadoo.fr> wrote:
> Follow the best practices, reorder the includes.
>
> While doing so, bump up copyright year of each modified files.
>
> Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
> ---
>
> Changelog:
>
> v1 -> v2:
>
> * rebase on linux-can-next/testing. v1 was based on a local branch
> and did not apply (sorry for the noise).
>
> * add the copyright bump. That was initially of this patch:
> https://lore.kernel.org/linux-can/20221104073659.414147-1-mailhol.vincent@wanadoo.fr/raw
> but figured out that it is better to put this next to the
> modifications of the includes.
> ---
> drivers/net/can/usb/etas_es58x/es581_4.c | 4 ++--
> drivers/net/can/usb/etas_es58x/es58x_core.c | 6 +++---
> drivers/net/can/usb/etas_es58x/es58x_fd.c | 4 ++--
The header file es58x_core.h also has some includes which are not
sorted correctly...
This was meant to be a trivial patch, but finally, it will need a
third revision. Please don’t take it, I will resend. And sorry for the
noise.
> 3 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/net/can/usb/etas_es58x/es581_4.c b/drivers/net/can/usb/etas_es58x/es581_4.c
> index 1bcdcece5ec7..4151b18fd045 100644
> --- a/drivers/net/can/usb/etas_es58x/es581_4.c
> +++ b/drivers/net/can/usb/etas_es58x/es581_4.c
> @@ -6,12 +6,12 @@
> *
> * Copyright (c) 2019 Robert Bosch Engineering and Business Solutions. All rights reserved.
> * Copyright (c) 2020 ETAS K.K.. All rights reserved.
> - * Copyright (c) 2020, 2021 Vincent Mailhol <mailhol.vincent@wanadoo.fr>
> + * Copyright (c) 2020-2022 Vincent Mailhol <mailhol.vincent@wanadoo.fr>
> */
>
> +#include <asm/unaligned.h>
> #include <linux/kernel.h>
> #include <linux/units.h>
> -#include <asm/unaligned.h>
>
> #include "es58x_core.h"
> #include "es581_4.h"
> diff --git a/drivers/net/can/usb/etas_es58x/es58x_core.c b/drivers/net/can/usb/etas_es58x/es58x_core.c
> index 51294b717040..7d6e688f2b46 100644
> --- a/drivers/net/can/usb/etas_es58x/es58x_core.c
> +++ b/drivers/net/can/usb/etas_es58x/es58x_core.c
> @@ -7,15 +7,15 @@
> *
> * Copyright (c) 2019 Robert Bosch Engineering and Business Solutions. All rights reserved.
> * Copyright (c) 2020 ETAS K.K.. All rights reserved.
> - * Copyright (c) 2020, 2021 Vincent Mailhol <mailhol.vincent@wanadoo.fr>
> + * Copyright (c) 2020-2022 Vincent Mailhol <mailhol.vincent@wanadoo.fr>
> */
>
> +#include <asm/unaligned.h>
> +#include <linux/crc16.h>
> #include <linux/ethtool.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
> #include <linux/usb.h>
> -#include <linux/crc16.h>
> -#include <asm/unaligned.h>
>
> #include "es58x_core.h"
>
> diff --git a/drivers/net/can/usb/etas_es58x/es58x_fd.c b/drivers/net/can/usb/etas_es58x/es58x_fd.c
> index c97ffa71fd75..fa87b0b78e3e 100644
> --- a/drivers/net/can/usb/etas_es58x/es58x_fd.c
> +++ b/drivers/net/can/usb/etas_es58x/es58x_fd.c
> @@ -8,12 +8,12 @@
> *
> * Copyright (c) 2019 Robert Bosch Engineering and Business Solutions. All rights reserved.
> * Copyright (c) 2020 ETAS K.K.. All rights reserved.
> - * Copyright (c) 2020, 2021 Vincent Mailhol <mailhol.vincent@wanadoo.fr>
> + * Copyright (c) 2020-2022 Vincent Mailhol <mailhol.vincent@wanadoo.fr>
> */
>
> +#include <asm/unaligned.h>
> #include <linux/kernel.h>
> #include <linux/units.h>
> -#include <asm/unaligned.h>
>
> #include "es58x_core.h"
> #include "es58x_fd.h"
> --
> 2.37.4
>
next prev parent reply other threads:[~2022-11-08 6:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-06 10:01 [PATCH] can: etas_es58x: sort the includes by alphabetic order Vincent Mailhol
2022-11-06 12:55 ` [PATCH v2] " Vincent Mailhol
2022-11-08 6:15 ` Vincent MAILHOL [this message]
2022-11-26 16:05 ` [PATCH v3] " Vincent Mailhol
2022-11-30 10:25 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMZ6RqKZJcSq=dMh84gacY3yh_4=XnW=Hupq4dZztE681ZACHg@mail.gmail.com' \
--to=mailhol.vincent@wanadoo.fr \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.