Re: [PATCH 2/3] can/peak_usb: add forgotten supported devices

From: Vincent MAILHOL <mailhol.vincent@wanadoo.fr>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Stephane Grosjean <s.grosjean@peak-system.com>,
	linux-can Mailing List <linux-can@vger.kernel.org>
Subject: Re: [PATCH 2/3] can/peak_usb: add forgotten supported devices
Date: Fri, 19 Mar 2021 18:47:06 +0900	[thread overview]
Message-ID: <CAMZ6RqL_ua4NzJ5VMC8Nw0iSXfBDDuOpabVJv+EEK82c4AsnEQ@mail.gmail.com> (raw)
In-Reply-To: <20210319083925.rvkbikpmkfxhjmr2@pengutronix.de>

On Fri. 19 Mar 2021 at 17:39, Marc Kleine-Budde <mkl@pengutronix.de> wrote:
> On 09.03.2021 16:28:37, Marc Kleine-Budde wrote:
> > On 09.03.2021 09:21:27, Stephane Grosjean wrote:
> > > Since the peak_usb driver also supports the CAN-USB interfaces
> > > "PCAN-USB X6" and "PCAN-Chip USB" from PEAK-System GmbH, this patch adds
> > > their names to the list of explicitly supported devices.
> > >
> > > Signed-off-by: Stephane Grosjean <s.grosjean@peak-system.com>
> > > ---
> > >  drivers/net/can/usb/peak_usb/pcan_usb_fd.c | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git a/drivers/net/can/usb/peak_usb/pcan_usb_fd.c b/drivers/net/can/usb/peak_usb/pcan_usb_fd.c
> > > index 6183a42f6491..8e6250c4c417 100644
> > > --- a/drivers/net/can/usb/peak_usb/pcan_usb_fd.c
> > > +++ b/drivers/net/can/usb/peak_usb/pcan_usb_fd.c
> > > @@ -19,6 +19,8 @@
> > >
> > >  MODULE_SUPPORTED_DEVICE("PEAK-System PCAN-USB FD adapter");
> > >  MODULE_SUPPORTED_DEVICE("PEAK-System PCAN-USB Pro FD adapter");
> > > +MODULE_SUPPORTED_DEVICE("PEAK-System PCAN-USB X6 adapter");
> > > +MODULE_SUPPORTED_DEVICE("PEAK-System PCAN-Chip USB");
> >
> > I've exchanged these, to correspond the order of the device ids.
>
> Funny side note:
> MODULE_SUPPORTED_DEVICE was a noop define. All uses have been globally
> removed from Linus' tree after this patch hit linux-net/master, but
> before it landed in Linus' tree.

Silly question but does it mean that we should not use
MODULE_SUPPORTED_DEVICE in newly submitted patches? After seeing
Stéphane's patch, I added it to my driver. Even if it is a noop
define, it adds meta information in the source code so I was
inclined to keep it.

Yours sincerely,
Vincent