Re: [GSoC][PATCH 0/1] add zero count optimization in ewah_bitmap.c

From: Aryan Gupta <garyan447@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Vicent Marti <tanoku@gmail.com>, git@vger.kernel.org
Subject: Re: [GSoC][PATCH 0/1] add zero count optimization in ewah_bitmap.c
Date: Mon, 11 Mar 2024 23:29:59 +0100	[thread overview]
Message-ID: <CAMbn=B5m7oeSy0tmChLRs=HKqAp7043s244jEKVFNayAxmcdUQ@mail.gmail.com> (raw)
In-Reply-To: <xmqqedcgvjik.fsf@gitster.g>

On Mon, Mar 11, 2024 at 5:08 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> Aryan Gupta <garyan447@gmail.com> writes:
>
> > Hey everyone
> >
> > I hope you are doing great. I came across a "todo" in the code base
> > which was based on zero count optimization. I tried to fix do it but
> > I am not sure if this was the required this or not.
>
> Do you mean that you are not sure if the improvement you made is
> what Vicent Marti meant by "zero count optimization" when e1273106
> (ewah: compressed bitmap implementation, 2013-11-14) was written?
>
Yes.
> Unfortunatelly, "what is "zero count optimization" in computer
> programming?" does not produce great hits, and you are probably
> better off to ask who wrote that comment (Cc'ed).
>
Sure.
> A few general pieces of advice:
>
>  * We usually don't do a cover letter for a single patch (instead we
>    write extra explanation after the three-dash line).
>
>  * An optimization patch usually is expected to come with
>    performance measurement, just like a bugfix patch is expected to
>    come with tests that show existing breakages that change the
>    behaviour for the better with the fix.
>
>  * Pay attention to coding style, as deviating from existing style
>    distracts reviewers and causes them to miss obvious bugs.
>
> Thanks.

Okay will take care of this. Thanks a lot.