From: Ard Biesheuvel <ardb@kernel.org>
To: Vamshi K Sthambamkadi <vamshi.k.sthambamkadi@gmail.com>
Cc: Matthew Garrett <matthew.garrett@nebula.com>,
Jeremy Kerr <jk@ozlabs.org>,
linux-efi <linux-efi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] efivarfs: fix memory leak in efivarfs_create()
Date: Mon, 26 Oct 2020 08:15:59 +0100 [thread overview]
Message-ID: <CAMj1kXEaLF7kvWORrTF+UM8qCbgzXzr4WLtOTM_aDm8Ggyao5Q@mail.gmail.com> (raw)
In-Reply-To: <20201023115429.GA2479@cosmos>
On Fri, 23 Oct 2020 at 13:54, Vamshi K Sthambamkadi
<vamshi.k.sthambamkadi@gmail.com> wrote:
>
> kmemleak report:
> unreferenced object 0xffff9b8915fcb000 (size 4096):
> comm "efivarfs.sh", pid 2360, jiffies 4294920096 (age 48.264s)
> hex dump (first 32 bytes):
> 2d 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 -...............
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> backtrace:
> [<00000000cc4d897c>] kmem_cache_alloc_trace+0x155/0x4b0
> [<000000007d1dfa72>] efivarfs_create+0x6e/0x1a0
> [<00000000e6ee18fc>] path_openat+0xe4b/0x1120
> [<000000000ad0414f>] do_filp_open+0x91/0x100
> [<00000000ce93a198>] do_sys_openat2+0x20c/0x2d0
> [<000000002a91be6d>] do_sys_open+0x46/0x80
> [<000000000a854999>] __x64_sys_openat+0x20/0x30
> [<00000000c50d89c9>] do_syscall_64+0x38/0x90
> [<00000000cecd6b5f>] entry_SYSCALL_64_after_hwframe+0x44/0xa9
>
> In efivarfs_create(), inode->i_private is setup with efivar_entry
> object which is never freed.
>
> Signed-off-by: Vamshi K Sthambamkadi <vamshi.k.sthambamkadi@gmail.com>
Queued as a fix, thanks!
> ---
> fs/efivarfs/super.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/efivarfs/super.c b/fs/efivarfs/super.c
> index 15880a6..f943fd0 100644
> --- a/fs/efivarfs/super.c
> +++ b/fs/efivarfs/super.c
> @@ -21,6 +21,7 @@ LIST_HEAD(efivarfs_list);
> static void efivarfs_evict_inode(struct inode *inode)
> {
> clear_inode(inode);
> + kfree(inode->i_private);
> }
>
> static const struct super_operations efivarfs_ops = {
> --
> 2.7.4
>
next prev parent reply other threads:[~2020-10-26 7:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 11:54 [PATCH] efivarfs: fix memory leak in efivarfs_create() Vamshi K Sthambamkadi
2020-10-26 7:15 ` Ard Biesheuvel [this message]
2020-11-17 17:47 ` [tip: efi/urgent] " tip-bot2 for Vamshi K Sthambamkadi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMj1kXEaLF7kvWORrTF+UM8qCbgzXzr4WLtOTM_aDm8Ggyao5Q@mail.gmail.com \
--to=ardb@kernel.org \
--cc=jk@ozlabs.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
--cc=vamshi.k.sthambamkadi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.