From: Ard Biesheuvel <ardb@kernel.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-crypto@vger.kernel.org, ebiggers@kernel.org,
James Bottomley <James.Bottomley@hansenpartnership.com>
Subject: Re: [PATCH v2] crypto: lib - implement library version of AES in CFB mode
Date: Sat, 11 Mar 2023 10:25:48 +0100 [thread overview]
Message-ID: <CAMj1kXF6_JFMFTqzmXWxM=zJ7HmDqnivAKjUT=pN-34werkd5g@mail.gmail.com> (raw)
In-Reply-To: <ZAxIKu3t4NJEGz6I@gondor.apana.org.au>
On Sat, 11 Mar 2023 at 10:21, Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> On Sat, Mar 11, 2023 at 10:02:01AM +0100, Ard Biesheuvel wrote:
> >
> > So we are basically going back to ablkcipher/blkcipher then? How about aead?
>
> No I just dug up the old blkcipher code and it's based on SGs
> just like skcipher.
>
> I went back to the beginning of git and we've only ever had
> an SG-based encryption interface. This would be the very first
> time that we've had this in the Crypto API.
>
> Do we have any potential users for such an AEAD interface?
>
Not sure. I just added the libaesgcm library interface, but that is
used in SMP secondary bringup, so that shouldn't use the crypto API in
any case.
Synchronous AEADs are being used in the wifi code, but I am not aware
of any problematic use cases.
So what use case is the driver for this sync skcipher change? And how
will this work with existing templates? Do they all have to implement
two flavors now?
next prev parent reply other threads:[~2023-03-11 9:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 14:43 [PATCH v2] crypto: lib - implement library version of AES in CFB mode Ard Biesheuvel
2023-02-20 4:44 ` Herbert Xu
2023-02-20 7:28 ` Ard Biesheuvel
2023-03-10 10:15 ` Herbert Xu
2023-03-10 16:18 ` Ard Biesheuvel
2023-03-11 8:06 ` Herbert Xu
2023-03-11 8:15 ` Ard Biesheuvel
2023-03-11 8:17 ` Herbert Xu
2023-03-11 8:42 ` Ard Biesheuvel
2023-03-11 8:47 ` Herbert Xu
2023-03-11 8:55 ` Ard Biesheuvel
2023-03-11 9:00 ` Herbert Xu
2023-03-11 9:02 ` Ard Biesheuvel
2023-03-11 9:21 ` Herbert Xu
2023-03-11 9:25 ` Ard Biesheuvel [this message]
2023-03-11 9:41 ` Herbert Xu
2023-03-12 8:06 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMj1kXF6_JFMFTqzmXWxM=zJ7HmDqnivAKjUT=pN-34werkd5g@mail.gmail.com' \
--to=ardb@kernel.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=ebiggers@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.