Re: [PATCH v2 1/2] pinctrl: renesas: Select CONFIG_IRQ_DOMAIN_HIERARCHY for pinctrl-rzg2l

From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Claudiu <claudiu.beznea@tuxon.dev>
Cc: linus.walleij@linaro.org, linux-renesas-soc@vger.kernel.org,
	 linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Subject: Re: [PATCH v2 1/2] pinctrl: renesas: Select CONFIG_IRQ_DOMAIN_HIERARCHY for pinctrl-rzg2l
Date: Wed, 21 Feb 2024 15:21:45 +0100	[thread overview]
Message-ID: <CAMuHMdU7jFzkX7dozKYnhp5RUPr4-1tG0Eba1he+t3nskagZMg@mail.gmail.com> (raw)
In-Reply-To: <CAMuHMdVi5vN5JSf9TAbdyrNa8_7eM=RajH8Mm=Qxhj5chWcK9A@mail.gmail.com>

On Wed, Feb 21, 2024 at 3:13 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Thu, Feb 15, 2024 at 1:41 PM Claudiu <claudiu.beznea@tuxon.dev> wrote:
> > From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> >
> > The pinctrl-rzg2l driver uses APIs that are defined only if
> > CONFIG_IRQ_DOMAIN_HIERARCHY=y (irq_chip_*_parent() APIs). On the ARCH_RZG2L
> > CONFIG_IRQ_DOMAIN_HIERARCHY is selected anyway, e.g., by the
> > CONFIG_ARM_GIC_V3. Even so, make it explicit at the driver level for a
> > clearer view of the dependencies.
> >
> > Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
>
> Thanks for your patch!
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Compile-testing on m68k reveals that you also need
>
>     select GPIOLIB_IRQCHIP

FTR:

drivers/pinctrl/renesas/pinctrl-rzg2l.c: In function ‘rzg2l_gpio_free’:
drivers/pinctrl/renesas/pinctrl-rzg2l.c:1472:30: error: ‘struct
gpio_chip’ has no member named ‘irq’
 1472 |  virq = irq_find_mapping(chip->irq.domain, offset);
      |                              ^~
drivers/pinctrl/renesas/pinctrl-rzg2l.c: In function
‘rzg2l_gpio_populate_parent_fwspec’:
drivers/pinctrl/renesas/pinctrl-rzg2l.c:1953:23: error: ‘struct
gpio_chip’ has no member named ‘irq’
 1953 |  fwspec->fwnode = chip->irq.parent_domain->fwnode;
      |                       ^~
drivers/pinctrl/renesas/pinctrl-rzg2l.c: In function ‘rzg2l_gpio_register’:
drivers/pinctrl/renesas/pinctrl-rzg2l.c:2057:14: error: ‘struct
gpio_chip’ has no member named ‘irq’
 2057 |  girq = &chip->irq;
      |              ^~

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds