Re: [PATCH] arm64: dts: renesas: r8a77961.dtsi: Enable Sound / Audio-DMAC

From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Magnus <magnus.damm@gmail.com>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	YUYA HAMAMACHI <yuya.hamamachi.sx@renesas.com>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	Yusuke Goda <yusuke.goda.sx@renesas.com>
Subject: Re: [PATCH] arm64: dts: renesas: r8a77961.dtsi: Enable Sound / Audio-DMAC
Date: Thu, 27 Aug 2020 09:57:16 +0200	[thread overview]
Message-ID: <CAMuHMdULmm9ZnZX83XtLnMZDOE53ebzPNZ-8VjCeyYu0jHMNVw@mail.gmail.com> (raw)
In-Reply-To: <87h7sovdvt.wl-kuninori.morimoto.gx@renesas.com>

Hi Morimoto-san,

Thanks for your patch!

On Thu, Aug 27, 2020 at 7:50 AM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> This patch enables Sound and Audio-DMAC for R-Car M3-W+ (R8A77961).
> It is tested on R-Car M3-W+ Salvator-XS board.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v5.10.

> --- a/arch/arm64/boot/dts/renesas/r8a77961.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77961.dtsi
> @@ -1230,27 +1230,494 @@ vin7: video@e6ef7000 {
>                 };
>
>                 rcar_sound: sound@ec500000 {
> +                       /*
> +                        * #sound-dai-cells is required
> +                        *
> +                        * Single DAI : #sound-dai-cells = <0>; <&rcar_sound>;
> +                        * Multi  DAI : #sound-dai-cells = <1>; <&rcar_sound N>;
> +                        */
> +                       /*
> +                        * #clock-cells is required for audio_clkout0/1/2/3
> +                        *
> +                        * clkout       : #clock-cells = <0>;   <&rcar_sound>;
> +                        * clkout0/1/2/3: #clock-cells = <1>;   <&rcar_sound N>;
> +                        */
> +                       compatible =  "renesas,rcar_sound-r8a77961", "renesas,rcar_sound-gen3";

Please make sure "renesas,rcar_sound-r8a77961" is added to the DT bindings
document, too.

Thank you!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds