Re: [PATCH v2] clk: renesas: cpg-mssr: Add R7S9210 support

From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Rob Herring <robh@kernel.org>
Cc: Chris Brandt <chris.brandt@renesas.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	linux-clk <linux-clk@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	Simon Horman <horms+renesas@verge.net.au>
Subject: Re: [PATCH v2] clk: renesas: cpg-mssr: Add R7S9210 support
Date: Thu, 30 Aug 2018 16:49:55 +0200	[thread overview]
Message-ID: <CAMuHMdUP=-EDJEk3wN9uVQHjRkimfwxvayV82gDT-XchYzrUNg@mail.gmail.com> (raw)
In-Reply-To: <CAL_JsqLF76sX=uhvBDOGTHRgZoqXWyUrnPGNmL6heUJmQBF8dA@mail.gmail.com>

Hi Rob,

On Thu, Aug 30, 2018 at 3:49 PM Rob Herring <robh@kernel.org> wrote:
> On Thu, Aug 30, 2018 at 3:05 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > On Wed, Aug 29, 2018 at 2:52 AM Rob Herring <robh@kernel.org> wrote:
> > > On Mon, Aug 27, 2018 at 11:21:39AM -0500, Chris Brandt wrote:
> > > > Add support for the R7S9210 (RZ/A2) Clock Pulse Generator and Module
> > > > Standby.
> > > >
> > > > The Module Standby HW in the RZ/A series is very close to R-Car HW, except
> > > > for how the registers are laid out.
> > > > The MSTP registers are only 8-bits wide, there is no status registers
> > > > (MSTPST), and the register offsets are a little different. Since the RZ/A
> > > > hardware manuals refer to these registers as the Standby Control Registers,
> > > > we'll use that name to distinguish the RZ/A type for the R-Car type.
> > > >
> > > > Signed-off-by: Chris Brandt <chris.brandt@renesas.com>
> > > > ---
> > >
> > > > +++ b/drivers/clk/renesas/r7s9210-cpg-mssr.c
> > > > @@ -0,0 +1,192 @@
> > > > +// SPDX-License-Identifier: GPL-2.0+
> > > > +/*
> > >
> > >
> > > > +++ b/include/dt-bindings/clock/r7s9210-cpg-mssr.h
> > > > @@ -0,0 +1,21 @@
> > > > +/* SPDX-License-Identifier: GPL-2.0+
> > >
> > > The proper identifier is GPL-2.0-or-later
> >
> > Documentation/process/license-rules.rst disagrees.
>
> Indeed, but: https://spdx.org/licenses/GPL-2.0+.html
>
> I think this changed about the time the kernel adopted SPDX. I guess
> it is fine as-is until we change the documentation.

Unlikely to happen, cfr.
https://lore.kernel.org/lkml/20180822194613.GB3457@kroah.com/
Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds